fix(miner): require a closing keyword in self-review's linked-PR extractor (#6769)

[shin-core]

Summary

self-review-context.js's LINKED_PR_PATTERN was a bare /\b(?:PR|pull request)\s+#(\d+)\b/gi — no closing-keyword requirement — while claiming to mirror src/db/repositories.ts's extractLinkedPrNumbers "exactly". Verified against current host source: the host requires a close[sd]?|fix(?:e[sd])?|resolve[sd]? prefix, specifically to avoid counting an incidental mention (its own #issue-body-pr-mention-pollution fix). The miner's copy never received it.

Impact: an issue body saying "similar to what we saw in PR #501" populated toIssueRecord's linkedPrs, which the engine's issue-quality report surfaces as "already references a PR" — so the miner skipped an issue that was actually available.

• Mirrored the host pattern exactly: /\b(?:close[sd]?|fix(?:e[sd])?|resolve[sd]?)\s+(?:PR|pull request)\s+#(\d+)\b/gi.
• Re-verified and corrected the "mirrors ... exactly" comment (per the issue's second requirement) to state why the keyword is required.

Closes #6769

Test plan

• REGRESSION: a bare "...similar to what we saw in PR #501, worth a look." body now yields linkedPrs: [].
• A real "Closes PR #501" body still yields linkedPrs: [501] (no over-rejection).
• Confirmed the tests are meaningful, not vacuous — against the old pattern the bare mention matched (1 hit, the bug); against the new one it matches 0, while Closes PR #501 still matches 1.
• test/unit/miner-self-review-context.test.ts green (30 tests); extended the existing file rather than adding a parallel one.
• npm run typecheck clean.

[superagent-security]

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.65%. Comparing base (fcf41bc) to head (5192411).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6862   +/-   ##
=======================================
  Coverage   93.64%   93.65%           
=======================================
  Files         685      685           
  Lines       68239    68239           
  Branches    18707    18707           
=======================================
+ Hits        63904    63906    +2     
+ Misses       3350     3348    -2     
  Partials      985      985           

Flag	Coverage Δ
shard-1	43.23% <0.00%> (-0.46%)	⬇️
shard-2	36.93% <100.00%> (+0.25%)	⬆️
shard-3	32.60% <0.00%> (-0.12%)	⬇️
shard-4	34.36% <0.00%> (-0.40%)	⬇️
shard-5	31.47% <0.00%> (+0.32%)	⬆️
shard-6	45.98% <100.00%> (+0.28%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/loopover-miner/lib/self-review-context.js	98.65% <100.00%> (+1.34%)	⬆️

[loopover-orb]

Warning

⏸️ LoopOver review result - manual review recommended

_{Review updated: 2026-07-17 09:22:30 UTC}

2 files · 1 AI reviewer · no blockers · CI green · unstable

⏸️ Suggested Action - Manual Review

Review summary
Fixes a real over-matching bug: the miner's LINKED_PR_PATTERN previously matched any bare 'PR #N' mention with no closing-keyword requirement, unlike the host's extractLinkedPrNumbers, causing incidental mentions to be misread as linked PRs and available issues to be skipped. The new regex correctly requires close[sd]?|fix(?:e[sd])?|resolve[sd]? as a prefix, mirroring the pattern already used for LINKED_ISSUE_PATTERN in the same file. Tests directly exercise both the regression case (bare mention → empty array) and the positive case (closing keyword → matched array), and the comment now explains the why rather than just asserting equivalence.

Nits — 3 non-blocking

• The regex doesn't strip code spans before matching, unlike extractLinkedIssueNumbers (self-review-context.js:229), so a backtick-quoted example like `Closes PR fix(signals): account for queue burden in readiness score #501` in a body would still be counted — minor inconsistency worth a follow-up if it matters in practice.
• The two new test cases are inserted between an existing `it` block and its following unrelated `it` block (test/unit/miner-self-review-context.test.ts) without a blank line before the next test, which is a formatting nit only.
• Consider applying the same code-span stripping used in extractLinkedIssueNumbers to extractLinkedPrNumbers for full parity with the host's guard against quoted examples.

Flagged checks (non-blocking)

• Contributor trust — Contributor flagged for review

Decision drivers

• ✅ Code review — No blockers (1 reviewer)
• ✅ Gate result — Passing (No configured blocker found.)

Context & advisory signals — never blocks the verdict

Signal	Result	Evidence
Linked issue	✅ Linked	#6769
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	❌ 8/20	High review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 49 registered-repo PR(s), 29 merged, 0 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	shin-core; Gittensor profile; 49 PR(s), 0 issue(s).
Improvement	✅ Minor	risk: clean · value: minor · LLM: moderate

Linked issue satisfaction

Addressed
The diff replaces the bare LINKED_PR_PATTERN with the closing-keyword-required regex exactly as specified in the issue, updates the misleading comment, and adds regression tests covering both the bare-mention false-positive and the true-positive 'Closes PR #501' case.

Review context

• Author: shin-core
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: TypeScript, JavaScript, Solidity, Dart, Python, CSS, PHP, Rust
• Official Gittensor activity: 49 PR(s), 0 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Start here: Add a concise scope and risk note.
• Then work through the remaining 1 step in the Signals table above.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

• @loopover ask <question> answers contribution-quality Q&A with source citations and freshness.
• @loopover chat <question> answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
• A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

• Re-run LoopOver review