fix(db): exclude webhook_events from destructive retention policy

[JSONbored]

Motivation

• Prevent deletion of webhook delivery idempotency records that the webhook handler relies on to suppress duplicate deliveries. Removing these rows enables replay attacks of previously valid signed webhooks.

Description

• Remove webhook_events from the RETENTION_POLICY in src/db/retention.ts so replay-prevention state is not eligible for destructive pruning.
• Clarify the retention comment to call out webhook delivery idempotency records as intentionally EXCLUDED from pruning in src/db/retention.ts.
• Update test/unit/retention.test.ts to assert that webhook_events is excluded from dry-run results, scheduled pruning, and the preview route, and to exercise pruning logic against ai_usage_events instead of webhook_events.
• Keep the existing batched delete, identifier guard, and audit behavior unchanged for other append-only tables.

Testing

• Ran the unit test file test/unit/retention.test.ts with npm test -- --run test/unit/retention.test.ts; all tests passed.
• Ran TypeScript type-check with npm run typecheck; it completed with no errors.
• Verified the modified tests reflect that webhook_events is no longer targeted by the default retention policy.

---

Codex Task

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[ghost]

Note

Gittensory Gate skipped

PR closed before full evaluation. No late first comment was created.

Signal	Result	Evidence	Action
Gate result	⚠️ Skipped	#666 is no longer open.	No action.

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

[ghost]

gittensory · advisory review

Reviewed 2 changed file(s) — two independent AI reviewers.

Suggested action: ✅ Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The PR removes webhook_events from the default retention policy and updates related tests to reflect that webhook events are now considered durable idempotency records and should not be pruned. The changes are straightforward, well‑documented, and the test suite has been adjusted accordingly.

Suggestions

• Add a brief comment in the retention module explaining why webhook_events are excluded (e.g., for replay/idempotency safety).
• Consider documenting this policy change in the project README or migration guide to inform operators about potential DB growth.

Worth double-checking

• Long‑term accumulation of webhook_events could increase DB storage; ensure monitoring/alerts are in place.
• Any external scripts that relied on the previous 30‑day prune for webhook_events may need to be updated.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The PR removes the webhook_events table from the retention policy, preventing its deletion after 30 days. The change is justified as webhook_events are durable replay/idempotency records requiring preservation. The test suite is updated consistently to reflect that webhook_events are no longer pruned, and all tests pass. No public/private boundary concerns are introduced.

Suggestions

• Consider adding a brief comment in the RETENTION_POLICY array near the removed line to explain why webhook_events were excluded (though the JSDoc above already covers this).
• The test file's removal of the unused eq import is appropriate and improves clarity.

Worth double-checking

• Verify that webhook_events growth remains bounded (e.g., via idempotency key limits or upstream deduplication) to prevent uncontrolled storage accumulation.
• Confirm no other retention policies or external processes implicitly rely on webhook_events deletion for cleanup.

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	gittensory-ui	dd220eb	Commit Preview URL Branch Preview URL	Jun 14 2026, 02:15 PM