fix: harden manifest public-safe filter - #659
Conversation
|
gittensory · advisory review Reviewed 3 changed file(s) — two independent AI reviewers. Suggested action: ✅ Safe to merge — both reviewers found no blocking issues. Reviewer A · Suggestions
Worth double-checking
Reviewer B · Suggestions
Worth double-checking
|
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Note Gittensory Gate skippedPR closed before full evaluation. No late first comment was created.
💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 6beaf3c | Commit Preview URL Branch Preview URL |
Jun 14 2026, 02:15 PM |
Motivation
.gittensory.ymlreview override could bypass the stricter public comment sanitizer and cause sensitive terms (e.g.seed phrase,private rankings) to be published under the GitHub App identity, so the manifest-level public-safe check needed to be aligned with the site-wide sanitizer.Description
isFocusManifestPublicSafeto block additional forbidden public-output terms and common plural/variant forms (coversseed phrase,private key, pluralrankings, score/scoreability/estimate variants, and related patterns) insrc/signals/focus-manifest.ts.footer/noteoverrides containing terms covered by the public comment sanitizer are dropped with warnings intest/unit/focus-manifest.test.ts.test/unit/policy-sanitizer.test.tsso the shared guard is exercised for the newly-covered terms.Testing
npm exec -- vitest run test/unit/focus-manifest.test.ts test/unit/policy-sanitizer.test.tsand the tests passed.npm run typecheck(tsc --noEmit) which completed successfully.Codex Task