fix(miner): wire DEPLOYMENT.md audit into real CI execution - #6524
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Add scripts/check-miner-deployment-docs.mjs (repo-root, not inside the published miner package) and invoke it from validate-code plus test:ci so doc drift fails CI as the audit module already claimed. Closes JSONbored#6158 Co-authored-by: Cursor <cursoragent@cursor.com>
validate-code rejected Partial ProcessEnv literals in the unit test; accept Record<string, string | undefined> instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6524 +/- ##
=======================================
Coverage 95.56% 95.56%
=======================================
Files 589 589
Lines 47121 47121
Branches 14989 14989
=======================================
Hits 45032 45032
Misses 1297 1297
Partials 792 792
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Warning ⏸️ LoopOver review result - manual review recommendedReview updated: 2026-07-16 12:07:51 UTC
Review summary Nits — 6 non-blocking
Decision drivers
Context & advisory signals — never blocks the verdict
Review context
Contributor next steps
Signal definitions
🧪 Chat with LoopOverAsk LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://loopover.ai/docs/loopover-commands 🧪 Experimental — new and may change. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
Summary
scripts/check-miner-deployment-docs.mjsthat runsassertDeploymentDocsInSyncagainst the live miner/engine trees and exits non-zero on drift.npm run test:miner-deployment-docs-auditintovalidate-code(miner lane) andtest:ci.packages/loopover-miner/so it cannot triptest:miner-pack(supersedes approach in closed fix(miner): wire deployment-docs audit into real CI execution #6465).missing-envdrift failure + CLI exit codes;.d.mtskeepsvalidate-codehappy.Closes #6158
Test plan
npx vitest run test/unit/check-miner-deployment-docs.test.ts test/unit/miner-deployment-docs-audit.test.ts(22 pass)npm run test:miner-deployment-docs-auditMade with Cursor