Skip to content

fix(miner): wire deployment-docs audit into real CI execution - #6465

Closed
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/miner-deployment-docs-audit-ci-6158
Closed

fix(miner): wire deployment-docs audit into real CI execution#6465
bohdansolovie wants to merge 1 commit into
JSONbored:mainfrom
bohdansolovie:fix/miner-deployment-docs-audit-ci-6158

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Summary

  • Adds a real executable checker script (packages/loopover-miner/scripts/check-deployment-docs-audit.mjs) that runs the existing deployment-docs audit against the live miner tree.
  • Wires that checker into CI (validate-code miner lane) via a new npm script so deployment-doc drift can actually fail CI as documented.
  • Adds focused script coverage (test/unit/miner-deployment-docs-audit-script.test.ts) for both pass and fail paths.

Closes #6158

Scope

  • Keeps the audit logic in lib/deployment-docs-audit.js unchanged
  • Adds only wiring (script + CI step + script test)
  • No unrelated workflow behavior changes

Validation

  • node packages/loopover-miner/scripts/check-deployment-docs-audit.mjs
  • npm run test -- test/unit/miner-deployment-docs-audit-script.test.ts
  • CI on this PR (will mark ready after green)

Safety

  • Miner/docs/CI wiring only
  • No protocol/scheme/economics changes
  • Failure mode is explicit and bounded to stale deployment-doc claims

Made with Cursor

@bohdansolovie
bohdansolovie marked this pull request as ready for review July 16, 2026 09:25
@bohdansolovie
bohdansolovie requested a review from JSONbored as a code owner July 16, 2026 09:26
@superagent-security superagent-security Bot added the contributor:flagged Contributor flagged for review by trust analysis. label Jul 16, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

🚨 Contributor flagged. Click here for more info: Superagent Dashboard

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 16, 2026
deployment-docs-audit.js claimed stale DEPLOYMENT.md docs would fail CI,
but the audit had no runtime caller. Add a real checker script, run it in
CI's miner lane, and cover the script with a focused unit test.

Closes JSONbored#6158

Co-authored-by: Cursor <cursoragent@cursor.com>
@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Caution

🛑 LoopOver review result - fixes required

Review updated: 2026-07-16 10:07:00 UTC

4 files · no blockers · CI failing · blocked

🛑 Suggested Action - Fix Blockers

  • AI review already in progress for this PR head: Another LoopOver pass is already running the AI review for this exact PR head. This pass is skipping to avoid a duplicate LLM call.

Review summary
AI review is already running for this PR head in another LoopOver pass. LoopOver is holding this PR for manual review until that pass completes.

Nits — 1 non-blocking
  • AI review already in progress for this PR head — The gate is held for a human reviewer rather than passed automatically; it re-evaluates once the in-flight review completes or on the next update.

CI checks failing

  • validate
  • validate-tests (5)
  • validate-tests (6)
  • validate-tests (2)
  • validate-code
Flagged checks (non-blocking)
  • Contributor trust — Contributor flagged for review

Decision drivers

  • ✅ Code review — No blockers (No AI review summary)
  • ⚠️ Gate result — Not blocking (Advisory; not blocking this PR.)
Context & advisory signals — never blocks the verdict
Signal Result Evidence
Linked issue ✅ Linked #6158
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ❌ 8/20 High review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 82 registered-repo PR(s), 30 merged, 6 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 82 PR(s), 6 issue(s).
Improvement ✅ Minor risk: clean · value: minor
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, C++, JavaScript
  • Official Gittensor activity: 82 PR(s), 6 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Start here: Add a concise scope and risk note.
  • Then work through the remaining 1 step in the Signals table above.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
🧪 Chat with LoopOver

Ask LoopOver a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @loopover ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @loopover chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @loopover mention with a real question is routed to the closest matching read-only command automatically — no exact syntax required.

Full command reference: https://loopover.ai/docs/loopover-commands

🧪 Experimental — new and may change.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb

loopover-orb Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

LoopOver is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (5), validate-tests (6), validate-tests (2), validate-code)). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor:flagged Contributor flagged for review by trust analysis. gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(miner): deployment-docs-audit.js claims to fail CI on doc drift but is wired into no CI/build step

1 participant