feat(miner): wire stack detection into the attempt prompt - #5722
Conversation
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5722 +/- ##
=======================================
Coverage 95.06% 95.06%
=======================================
Files 581 581
Lines 46169 46179 +10
Branches 14811 14811
=======================================
+ Hits 43891 43901 +10
Misses 1517 1517
Partials 761 761
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ LoopOver review result - approve/merge recommendedReview updated: 2026-07-14 08:06:00 UTC
✅ Suggested Action - Approve/Merge
Review summary Nits — 5 non-blocking
Flagged checks (non-blocking)
Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
…ck commands (JSONbored#4786) - Updated README to clarify the integration of the detected stack into coding-agent instructions. - Modified `coding-task-spec.d.ts` to include an injectable `detectRepoStack` function for improved stack detection. - Enhanced `coding-task-spec.js` to append real stack summaries and confidently inferred commands to the agent's prompt, ensuring validation against the target repo's tooling. - Added unit tests to verify the correct embedding of detected stack commands and handling of undetected stacks, ensuring no assumptions are made about LoopOver/gittensory CI conventions.
324d55e to
10c53b2
Compare
Summary
Closes #4786.
Fresh PR after #5717 (auto-closed for red CI on an unrelated main-branch Grafana test drift). Same feature, plus the missing test sync so
validate-tests (6)can go green.detectRepoStack/renderStackSummary(#4785) already return a structured target-repo stack, but nothing in the attempt path consumed them. This wires the real detection intobuildCodingTaskSpecinstructions so the coding agent validates against THIS repo's tooling instead of assuming LoopOver/gittensory CI, Codecov, ornpm run test:ci.Also finishes the #5716 follow-up that left
maintainer-reviews.jsonon__ALL__whileselfhost-grafana-dashboard.test.tsstill asserted$__all— that mismatch is what redlined shard 6 on every recent PR (including #5717).How
coding-task-spec.js— after a ready acceptance-criteria write, calldetectRepoStack(workingDirectory)(injectable; production default is the real detector) and append validation guidance: stack summary, "do not assume gittensory CI", and only non-null commands (fail-closed, no guessing).selfhost-grafana-dashboard.test.ts— alignexpandGrafanaRange+ assertions with__ALL__(same sentinel asai-usage/miner-usageafter fix(observability): stop using Grafana's $__ macro prefix as the SQL "All" sentinel #5716).Acceptance criteria
instructions__ALL__and no longer expect$__allOut of scope: replacing self-review's LoopOver predicted-gate with foreign-repo check-run success.
Tests
npx vitest run test/unit/miner-coding-task-spec.test.tsnpx vitest run test/unit/selfhost-grafana-dashboard.test.tsScope
CONTRIBUTING.mdCloses #4786Validation
git diff --checknpm run test:ci(run before push)Safety