feat(miner): wire stack detection into the coding-task attempt prompt - #5717
feat(miner): wire stack detection into the coding-task attempt prompt#5717carlh7777 wants to merge 1 commit into
Conversation
…ck commands (JSONbored#4786) - Updated README to clarify the integration of detected stack commands into coding-agent instructions. - Modified `coding-task-spec.d.ts` to include an injectable `detectRepoStack` function for improved stack detection. - Enhanced `coding-task-spec.js` to utilize the detected stack information, ensuring the agent validates against the target repo's tooling rather than default assumptions. - Added tests to verify that detected stack commands are correctly embedded in the coding-agent instructions and handle various scenarios, including undetected stacks and partial command detection. This update improves the accuracy of the coding-agent's guidance by leveraging real repository configurations, addressing issues raised in JSONbored#4786.
|
🚨 Contributor flagged. Click here for more info: Superagent Dashboard |
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
❌ 7 Tests Failed:
View the full list of 7 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 LoopOver review result - reject/close recommendedReview updated: 2026-07-14 07:27:50 UTC
🛑 Suggested Action - Reject/Close Review summary Blockers
Nits — 5 non-blocking
Why this is blocked
📋 Copy for AI agents — paste into your coding agentCI checks failing
Flagged checks (non-blocking)
Linked issue satisfactionNot yet addressed Review context
Contributor next steps
Signal definitions
[BETA] Chat with GittensoryAsk Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.
Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (CI is failing (validate, validate-tests (6)); AI reviewers agree on a likely critical defect: CI shows `validate` and `validate-tests (6)` FAILED on this commit — that must be resolved or explained before merge since it's unclear from the diff alone whether it's related to this change (e.g. a stack-detection.js signature mismatch or an unrelated shard).). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
Closes #4786.
detectRepoStack/renderStackSummary(#4785) already return a structured target-repo stack (language, package manager, build/test/lint/format commands), but nothing in the attempt path consumed them —buildCodingTaskSpec's instructions were issue text + an acceptance-criteria path only. This wires the real detection result into the coding-agent prompt so the agent validates against THIS repository's tooling rather than assuming LoopOver/gittensory CI, Codecov, ornpm run test:ci.How
coding-task-spec.js— after a ready acceptance-criteria write, calldetectRepoStack(workingDirectory)(injectable for tests; production default is the real detector) and appendbuildValidationGuidanceto instructions: stack summary, an explicit "do not assume gittensory CI" clause, and only the confidently-inferred commands (null commands stay omitted — fail-closed, no guessing).{ detected: false }results still reach the prompt viarenderStackSummary, so detection failure is honest rather than a silent npm/Codecov default.Acceptance criteria
instructionsOut of scope: replacing self-review's LoopOver predicted-gate with foreign-repo check-run success (larger follow-up on the same epic).
Tests
test/unit/miner-coding-task-spec.test.ts— detected Node scripts, fail-closed empty worktree, no-command detected stack, production default detector (Cargo.toml), and both sides of each command ternary (build/test vs lint/format).Scope
type(scope): short summaryConventional Commit formatCONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAMECloses #4786Validation
npx vitest run test/unit/miner-coding-task-spec.test.tsgit diff --checknpm run test:ci/ full gate (run before push)Safety