Skip to content

fix(queue): migrate data-fidelity repair from isRegistered to isInstalled #5696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 14, 2026
Merged

fix(queue): migrate data-fidelity repair from isRegistered to isInstalled #5696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/queue/processors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4364,7 +4364,10 @@ export async function repairDataFidelity(
segmentsByRepo.set(segment.repoFullName, complete);
}
}
const registeredRepos = repositories.filter((repo) => repo.isRegistered);
// #5020: cache hygiene for cached labels/issues/PRs has nothing to do with subnet economics -- scope to
// repos this instance actually operates on (isInstalled), matching #5021's retarget of the underlying
// backfill job this function dispatches.
const registeredRepos = repositories.filter((repo) => repo.isInstalled);
const freshnessSlo = buildFreshnessSloReport({
repoCount: registeredRepos.length,
segments,
Expand Down
43 changes: 40 additions & 3 deletions test/unit/queue.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,9 +752,12 @@ describe("queue processors", () => {
"we-promise/sure": { emission_share: 0.02, issue_discovery_share: 0, label_multipliers: {}, trusted_label_pipeline: false },
},
{ kind: "raw-github", url: "fixture://registry" },
"2026-05-25T00:00:00.000Z",
"2026-05-23T00:00:00.000Z",
),
);
// repairDataFidelity now gates on isInstalled, not isRegistered (#5020).
await upsertRepositoryFromGitHub(env, { name: "gittensory", full_name: "JSONbored/gittensory", private: true, owner: { login: "JSONbored" } }, 9410);
await upsertRepositoryFromGitHub(env, { name: "sure", full_name: "we-promise/sure", private: true, owner: { login: "we-promise" } }, 9411);

await upsertRepoSyncSegment(env, completeSegment("JSONbored/gittensory", "labels"));
await upsertRepoSyncSegment(env, completeSegment("JSONbored/gittensory", "open_issues"));
Expand All @@ -770,6 +773,35 @@ describe("queue processors", () => {
);
});

it("dispatches fidelity repair by isInstalled, not isRegistered (#5020 regression)", async () => {
const sent: import("../../src/types").JobMessage[] = [];
const env = createTestEnv({
JOBS: {
async send(message: import("../../src/types").JobMessage) {
sent.push(message);
},
} as unknown as Queue,
});
// Installed but not gittensor-subnet-registered: cache hygiene for cached labels/issues/PRs has
// nothing to do with subnet economics, so this repo MUST still be covered.
await upsertRepositoryFromGitHub(env, { name: "installed-not-registered", full_name: "acme/installed-not-registered", private: false, owner: { login: "acme" } }, 9415);
// Subnet-registered but not installed on this instance: this repo must NOT be covered.
await persistRegistrySnapshot(
env,
normalizeRegistryPayload(
{ "acme/registered-not-installed": { emission_share: 0.01, issue_discovery_share: 0, label_multipliers: {}, trusted_label_pipeline: false } },
{ kind: "raw-github", url: "fixture://registry" },
"2026-05-23T00:00:00.000Z",
),
);

await processJob(env, { type: "repair-data-fidelity", requestedBy: "api" });

const repairedRepos = sent.map((message) => (message as { repoFullName?: string }).repoFullName);
expect(repairedRepos).toContain("acme/installed-not-registered");
expect(repairedRepos).not.toContain("acme/registered-not-installed");
});

it("marks fidelity repair completed when only signal refreshes are needed", async () => {
vi.useFakeTimers();
vi.setSystemTime(new Date("2026-05-25T01:00:00.000Z"));
Expand All @@ -790,9 +822,12 @@ describe("queue processors", () => {
"we-promise/sure": { emission_share: 0.02, issue_discovery_share: 0, label_multipliers: {}, trusted_label_pipeline: false },
},
{ kind: "raw-github", url: "fixture://registry" },
"2026-05-25T00:00:00.000Z",
"2026-05-23T00:00:00.000Z",
),
);
// repairDataFidelity now gates on isInstalled, not isRegistered (#5020).
await upsertRepositoryFromGitHub(env, { name: "gittensory", full_name: "JSONbored/gittensory", private: true, owner: { login: "JSONbored" } }, 9412);
await upsertRepositoryFromGitHub(env, { name: "sure", full_name: "we-promise/sure", private: true, owner: { login: "we-promise" } }, 9413);
for (const repoFullName of ["JSONbored/gittensory", "we-promise/sure"]) {
await upsertRepoSyncSegment(env, completeSegment(repoFullName, "labels"));
await upsertRepoSyncSegment(env, completeSegment(repoFullName, "open_issues"));
Expand Down Expand Up @@ -838,9 +873,11 @@ describe("queue processors", () => {
normalizeRegistryPayload(
{ "JSONbored/gittensory": { emission_share: 0.01, issue_discovery_share: 0, label_multipliers: {}, trusted_label_pipeline: false } },
{ kind: "raw-github", url: "fixture://registry" },
"2026-05-25T00:00:00.000Z",
"2026-05-23T00:00:00.000Z",
),
);
// repairDataFidelity now gates on isInstalled, not isRegistered (#5020).
await upsertRepositoryFromGitHub(env, { name: "gittensory", full_name: "JSONbored/gittensory", private: true, owner: { login: "JSONbored" } }, 9414);
await upsertRepoSyncSegment(env, completeSegment("JSONbored/gittensory", "labels"));
await upsertRepoSyncSegment(env, completeSegment("JSONbored/gittensory", "open_issues"));
await upsertRepoSyncSegment(env, completeSegment("JSONbored/gittensory", "open_pull_requests"));
Expand Down