Skip to content

fix(queue): migrate data-fidelity repair from isRegistered to isInstalled - #5696

Merged
JSONbored merged 1 commit into
mainfrom
fix/data-fidelity-isinstalled-5020
Jul 14, 2026
Merged

fix(queue): migrate data-fidelity repair from isRegistered to isInstalled#5696
JSONbored merged 1 commit into
mainfrom
fix/data-fidelity-isinstalled-5020

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

  • repairDataFidelity (src/queue/processors.ts) filtered repositories.filter(isRegistered) to decide which repos' cached labels/issues/PRs get freshness-checked and repaired.
  • This is pure cache hygiene for any repo gittensory reviews — unrelated to gittensor-subnet economics — and it drives dispatch of the backfill-registered-repos job family, which Retarget the backfill-registered-repos job family from isRegistered to isInstalled #5021 already retargeted to isInstalled. Both should agree on the same scoping signal.

Test plan

Closes #5020

…lled

repairDataFidelity filtered repositories.filter(isRegistered) to decide
which repos' cached labels/issues/PRs get freshness-checked and
repaired. This is cache hygiene for any repo gittensory reviews, unrelated
to subnet economics -- and it drives dispatch of the backfill-registered-repos
job family #5021 already retargeted to isInstalled, so both should agree
on the same scoping signal.

Closes #5020
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (21d13b2) to head (17de0fd).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5696   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         577      577           
  Lines       45978    45978           
  Branches    14724    14724           
=======================================
  Hits        43689    43689           
  Misses       1530     1530           
  Partials      759      759           
Flag Coverage Δ
shard-1 43.63% <100.00%> (-0.42%) ⬇️
shard-2 35.84% <0.00%> (+0.06%) ⬆️
shard-3 32.33% <0.00%> (-0.09%) ⬇️
shard-4 33.04% <0.00%> (-0.02%) ⬇️
shard-5 31.51% <0.00%> (-0.26%) ⬇️
shard-6 44.62% <0.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/queue/processors.ts 95.67% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 14, 2026
@loopover-orb

loopover-orb Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ LoopOver review result - manual review recommended

Review updated: 2026-07-14 05:35:23 UTC

2 files · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

⏸️ Suggested Action - Manual Review

  • Touches a guarded path — held for manual review: This PR changes guardrail-protected path(s): src/queue/processors.ts (matched src/queue/**).

Review summary
This is a narrow one-line scoping fix: repairDataFidelity now filters repositories by isInstalled instead of isRegistered, aligning cache-hygiene repair dispatch with #5021's retarget of the underlying backfill job. The change is well-justified (cache hygiene for labels/issues/PRs shouldn't depend on subnet registration), closes the linked #5020, and is backed by a new regression test that explicitly asserts an installed-not-registered repo is included and a registered-not-installed repo is excluded. Existing tests were updated with upsertRepositoryFromGitHub calls to keep repos marked installed, which is consistent with the new gating logic.

Nits — 5 non-blocking
  • The three near-identical inline comments citing Migrate data-fidelity repair from isRegistered to isInstalled #5020 (src/queue/processors.ts and twice in test/unit/queue.test.ts) are repetitive — one clear comment at the source change would suffice.
  • The date shift from 2026-05-25 to 2026-05-23 in the registry snapshot timestamps across multiple tests isn't explained — confirm this is required for the isInstalled gating and not incidental churn.
  • Consider extracting the repeated upsertRepositoryFromGitHub setup pattern for 'installed' fixtures into a small test helper to reduce duplication across the four call sites in test/unit/queue.test.ts.
  • PR author also opened the linked issue — Link an issue that was opened by a different contributor, or provide a rationale for why this self-authored issue represents genuine discovery work.
  • Touches a guarded path — held for manual review — A maintainer must review and merge this change.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #5020
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ✅ 25/25 PR body includes validation/test evidence.
Contributor workload ✅ 10/10 Author activity: 45 registered-repo PR(s), 37 merged, 320 issue(s).
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 45 PR(s), 320 issue(s).
Gate result ⚠️ Not blocking Advisory; not blocking this PR.
Improvement ✅ Minor risk: clean · value: minor — Code changes are accompanied by test evidence.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, Ruby, Go, JavaScript, MDX, Shell, Solidity
  • Official Gittensor activity: 45 PR(s), 320 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
[BETA] Chat with Gittensory

Ask Gittensory a question about this PR directly in a comment — grounded only in the same cached, public-safe facts shown above, never a new claim.

  • @gittensory ask &lt;question&gt; answers contribution-quality Q&A with source citations and freshness.
  • @gittensory chat &lt;question&gt; answers in natural prose from cached decision-pack facts via local inference (maintainer/collaborator; read-only).
  • A plain-language @gittensory mention with a real question is routed to the closest matching read-only command automatically -- no exact syntax required.

Full command reference: https://gittensory.aethereal.dev/docs/gittensory-commands

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by LoopOver, a quiet PR intelligence layer for OSS maintainers.

  • Re-run LoopOver review

@loopover-orb loopover-orb Bot added the manual-review Gittensor contributor context label Jul 14, 2026
@JSONbored
JSONbored merged commit e4b3af8 into main Jul 14, 2026
17 checks passed
@JSONbored
JSONbored deleted the fix/data-fidelity-isinstalled-5020 branch July 14, 2026 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. manual-review Gittensor contributor context

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate data-fidelity repair from isRegistered to isInstalled

1 participant