Skip to content

refactor(infra): retire the drained gittensory-jobs/-dlq queues #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 1 commit into from
Jul 13, 2026
Merged

refactor(infra): retire the drained gittensory-jobs/-dlq queues #5573

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 8 additions & 27 deletions wrangler.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,18 +275,15 @@
"new_sqlite_classes": ["RateLimiter"],
},
],
// Queue rename (#4768): the producer now writes ONLY to the new loopover-jobs queue. The old gittensory-jobs
// queue is kept as a consumer below (drain window) so any message already in flight at cutover still gets
// processed -- remove the 2 gittensory-jobs* consumer entries once `wrangler queues info gittensory-jobs`
// shows it's been empty for a while, then retire the gittensory-jobs/-dlq queues themselves.
// Queue rename (#4768): the producer writes to loopover-jobs. The old gittensory-jobs/-dlq drain-window
// consumers were removed once `wrangler queues info gittensory-jobs` confirmed 0 producers and the queue
// fully drained -- those two queues are retired (no longer bound here at all).
//
// gittensory-webhooks/-dlq are deliberately NOT part of this rename: the WEBHOOKS binding (src/env.d.ts) is
// only ever read by enqueueWebhookByEnv's self-host-only code path (gated behind isSelfHostedReviewRuntime,
// which is always false on this hosted Worker -- see src/github/webhook.ts) -- direct-review-app webhook
// enqueue is retired in favor of the Orb broker's /v1/orb/webhook ingress. The live gittensory-webhooks
// queue's consumer binding to this Worker appears to be leftover from before that retirement (0 producers,
// confirmed via `wrangler queues info gittensory-webhooks`) -- out of scope to migrate; flagging as a
// separate dead-infrastructure cleanup candidate rather than perpetuating it under a new name.
// gittensory-webhooks/-dlq were never part of this rename: the WEBHOOKS binding (src/env.d.ts) is only ever
// read by enqueueWebhookByEnv's self-host-only code path (gated behind isSelfHostedReviewRuntime, which is
// always false on this hosted Worker -- see src/github/webhook.ts) -- direct-review-app webhook enqueue is
// retired in favor of the Orb broker's /v1/orb/webhook ingress. Those two queues had 0 producers (leftover
// from before that retirement) and were deleted outright rather than renamed.
"queues": {
"producers": [
{
Expand Down Expand Up @@ -324,22 +321,6 @@
"max_batch_timeout": 30,
"max_retries": 0,
},
// --- Drain-window consumers for the old gittensory-jobs* queues (#4768) -- remove once confirmed empty ---
{
"queue": "gittensory-jobs",
"max_batch_size": 5,
"max_batch_timeout": 5,
"max_concurrency": 3,
"max_retries": 3,
"retry_delay": 30,
"dead_letter_queue": "gittensory-jobs-dlq",
},
{
"queue": "gittensory-jobs-dlq",
"max_batch_size": 10,
"max_batch_timeout": 30,
"max_retries": 0,
},
],
},
"triggers": {
Expand Down