refactor(infra): retire the drained gittensory-jobs/-dlq queues - #5573
Merged
Conversation
The old gittensory-jobs/-dlq drain-window consumers (added in #5558) are removed now that `wrangler queues info gittensory-jobs` confirms 0 producers and the queue fully drained -- the JOBS producer has been writing exclusively to loopover-jobs since that PR merged. Completes the #4768 queue rename; the Cloudflare-side queue objects themselves are deleted directly (not tracked in code) once this deploys and the consumer binding that currently blocks deletion is released. Closes #4768.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5573 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 573 573
Lines 45469 45469
Branches 14680 14680
=======================================
Hits 43187 43187
Misses 1531 1531
Partials 751 751
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
loopover-orb
Bot
added
the
gittensor:bug
Contributor
|
Important 🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪 🔍 Gittensory is reviewing…AI analysis is in progress. This comment will update when the review is complete. 🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The old
gittensory-jobs/-dlqdrain-window consumers (added in #5558) are removed now thatwrangler queues info gittensory-jobsconfirms 0 producers and the queue has fully drained — theJOBSproducer has been writing exclusively toloopover-jobssince that PR merged.Once this deploys, the actual Cloudflare-side queue objects will be deleted directly (they can't be deleted while a consumer binding still references them — that binding goes away when this config deploys).
Test plan
wrangler queues info gittensory-jobsconfirmed 0 producers before removing the consumer entries.npm run test:cigate green.cf-typegen:checkclean after rebase.Closes #4768.