Skip to content

fix(chat): target publicSafeSummary in the private-lane-signal redaction test #5211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 1 commit into from
Closed

fix(chat): target publicSafeSummary in the private-lane-signal redaction test #5211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/unit/ai-chat-qa.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,12 +262,11 @@ describe("generateChatQaAnswer", () => {
const run = vi.fn(async () => ({ response: "Public-safe readiness answer." }));
const env = createTestEnv({ AI_ADVISORY: { run } as unknown as Ai, AI_DAILY_NEURON_BUDGET: "10000" });
const result = await generateChatQaAnswer(env, {
// publicSafeSummary (unlike why/blockedBy, dropped from the grounding bundle entirely -- #5106) is the
// one action field that still reaches redactGroundingText, so it's the field this test must seed.
bundle: bundleFixture(undefined, {
why: [
"owner/repo: Maintainer cut: 1.",
"owner/repo: split lane (direct PR 1, issue-discovery 1); both lanes are useful here.",
"owner/repo: direct PR lane share 1 with no hard personal blocker.",
],
publicSafeSummary:
"owner/repo: Maintainer cut: 1. owner/repo: split lane (direct PR 1, issue-discovery 1); both lanes are useful here. owner/repo: direct PR lane share 1 with no hard personal blocker.",
}),
question: "what should I know?",
advisoryAiRouting: ADVISORY_ON,
Expand Down