fix(chat): target publicSafeSummary in the private-lane-signal redaction test - #5211
Closed
JSONbored wants to merge 1 commit into
Closed
fix(chat): target publicSafeSummary in the private-lane-signal redaction test#5211JSONbored wants to merge 1 commit into
JSONbored wants to merge 1 commit into
Conversation
…ion test The private-lane-signal redaction test (#5149) seeded the private-lane phrasing into the action's why field, but #5106 already dropped why/ blockedBy from the grounding bundle entirely (a stronger data-minimization boundary than field-level redaction). The two changes don't textually conflict, but merged together the test asserts on content that no longer reaches the prompt at all -- currently failing on main. publicSafeSummary is the one action field #5106 still forwards through redactGroundingText, so it's the field this test needs to seed.
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Owner
Author
|
Superseded — #5201 fixed the same root cause (ai-chat-qa.test.ts's why→publicSafeSummary field) and merged first. Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main(CI red since the fix(chat): redact private lane signals from Q&A #5149/fix(chat): restrict grounding to public summaries #5106 merge sequence).whyfield. fix(chat): restrict grounding to public summaries #5106 (merged earlier the same session) had already droppedwhy/blockedByfrom the grounding bundle entirely as a stronger data-minimization boundary. Neither PR conflicted textually, but combined, the test now asserts on content that never reaches the prompt.publicSafeSummary, the one action field fix(chat): restrict grounding to public summaries #5106 still forwards throughredactGroundingText— restores the test's actual intent (private-lane phrasing gets redacted before the prompt is built) against current behavior.Validation
npx vitest run test/unit/ai-chat-qa.test.ts— 31/31 passing (was 1 failing on main).npm run typecheck— clean.src/**production code touched.