Skip to content

test(config): lock in review.impact_map plumbing (#2184) #4419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loopover-orb merged 1 commit into from
Jul 9, 2026
Merged

test(config): lock in review.impact_map plumbing (#2184) #4419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions test/unit/config-templates.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,20 @@ describe("config/examples review templates (#1682)", () => {
expect(reviewConfigToJson(on.review)).toEqual({ inline_comments_per_category: 2 });
});

it("resolves review.impact_map via manifest parse + boolean helper (#2184)", () => {
const full = readConfigExample("gittensory.full.yml");
expect(full).toMatch(/# impact_map:/);
expect(parseFocusManifest({}).review.impactMap).toBeNull();
expect(resolveReviewPromptOverrides(parseFocusManifest({})).impactMap).toBe(false);
const on = parseFocusManifest({ review: { impact_map: true } });
expect(on.review.impactMap).toBe(true);
expect(resolveReviewPromptOverrides(on).impactMap).toBe(true);
expect(reviewConfigToJson(on.review)).toEqual({ impact_map: true });
const off = parseFocusManifest({ review: { impact_map: false } });
expect(off.review.impactMap).toBe(false);
expect(resolveReviewPromptOverrides(off).impactMap).toBe(false);
});

it("parses gittensory.minimal.yml with zero warnings and enables no agent actions", () => {
const manifest = parseFocusManifestContent(readConfigExample("gittensory.minimal.yml"), "repo_file");
expect(manifest.warnings).toEqual([]);
Expand Down