test(config): lock in review.impact_map plumbing (#2184)

[luciferlive112116]

Closes #1680

Summary

• Add a config-templates inventory test that locks in the shipped review.impact_map plumbing: docs entry in gittensory.full.yml, manifest parse round-trip, and resolveReviewPromptOverrides boolean helper (unset → false).

Validation

• npx vitest run test/unit/config-templates.test.ts

UI Evidence

N/A — test-only.

[superagent-security]

Superagent didn't find any vulnerabilities or security issues in this PR.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.98%. Comparing base (fa37b62) to head (c76e787).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4419   +/-   ##
=======================================
  Coverage   93.98%   93.98%           
=======================================
  Files         407      407           
  Lines       37040    37040           
  Branches    13540    13540           
=======================================
  Hits        34813    34813           
  Misses       1570     1570           
  Partials      657      657           

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[loopover-orb]

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

_{Review updated: 2026-07-09 17:20:26 UTC}

1 file · 1 AI reviewer · no blockers · readiness 100/100 · CI green · clean

✅ Suggested Action - Approve/Merge

• safe to merge

Review summary
This is a test-only PR that adds one `it()` block to test/unit/config-templates.test.ts mirroring the exact pattern already used for changed_files_summary (#2146) and effort_score (#2152): it checks that gittensory.full.yml documents `impact_map`, that parseFocusManifest defaults it to null, that resolveReviewPromptOverrides coerces unset to false, and that on/off values round-trip through parse and reviewConfigToJson. The diff introduces no production code, so it presumes review.impactMap/impact_map already ships in src/signals/focus-manifest.ts and config/examples/gittensory.full.yml — neither file is included in the provided context, so that underlying wiring can't be independently confirmed here, but the test shape is structurally identical to the two prior accepted tests for sibling boolean toggles and CI (including codecov/patch) passed on this commit.

Nits — 4 non-blocking

• PR description says 'Closes feat(selfhost): complete review configuration control surface #1680' (the broad 'complete review configuration control surface' tracking issue), but the external brief notes only partial coverage of that issue and the test itself is tagged feat(config): add review.impact_map toggle (default off) for the impact map #2184 — worth confirming feat(selfhost): complete review configuration control surface #1680 should actually be closed by this narrow test-only change rather than linked as a partial step.
• Cannot verify from the diff alone that config/examples/gittensory.full.yml actually contains the `# impact_map:` comment or that focus-manifest.ts exposes `impactMap`/`reviewConfigToJson` support for it — since this PR ships no src changes, that plumbing must already exist; worth a quick confirm against src/signals/focus-manifest.ts.
• Confirm the parent issue feat(selfhost): complete review configuration control surface #1680 is either fully closed by the sum of these incremental test PRs or re-link this one to the specific sub-issue it addresses, per the repo's issue-scope convention.
• No code changes needed; if impact_map's src-side implementation hasn't landed yet in a separate PR, this test would currently fail, so double check it against main before merge.

Signal	Result	Evidence
Code review	✅ No blockers	1 reviewer
Linked issue	✅ Linked	#1680
Related work	✅ No active overlap found	No same-issue or scoped active PR overlap found.
Change scope	✅ 20/20	Low review scope from cached public metadata (1 linked issue).
Validation posture	✅ 25/25	PR body includes validation/test evidence.
Contributor workload	✅ 10/10	Author activity: 164 registered-repo PR(s), 69 merged, 35 issue(s).
Contributor context	✅ Confirmed Gittensor contributor	luciferlive112116; Gittensor profile; 164 PR(s), 35 issue(s).
Gate result	✅ Passing	No configured blocker found.

Linked issue satisfaction

Not yet addressed
This issue asks for a coherent operator control surface (child issues for templates, REES analyzer controls, CodeRabbit-style controls, dashboard generator, a shared acceptance checklist, and correct labeling/linking), but the PR only adds a unit test locking in existing review.impact_map parsing behavior and closes a different issue (#1680) not listed among this issue's children. The diff shows n

Review context

• Author: luciferlive112116
• Role context: outside_contributor
• Public audience mode: oss maintainer
• Lane context: Repository is configured for direct PR review.
• Public profile languages: JavaScript, Python, MDX, Rust, TypeScript
• Official Gittensor activity: 164 PR(s), 35 issue(s).
• PR-specific overlap: none found.

Contributor next steps

• Keep the PR focused and include validation evidence before maintainer review.

Signal definitions

• Related work = same linked issue, overlapping active PRs, or title/path similarity.
• Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
• Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
• Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
• Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

_{🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed}

---

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

• Re-run Gittensory review

[loopover-orb]

Gittensory approves — the gate is satisfied and CI is green.