fix(review): make manifest_missing_tests CI- and bot-aware - #4406
Merged
Conversation
passedValidationCount previously came only from a PR-body prose match, with no connection to the PR's real CI results, and no bot-author exemption existed anywhere in this deterministic gate path — confirmed false positive on JSONbored/awesome-claude PR #4719 (a CI-green, github-actions[bot] README-regen PR flagged as missing test evidence). Now also consults the PR's live CI state (a fully-green rollup counts as evidence) and exempts authors matching review.auto_review.ignore_authors, mirroring the existing AI-review skip. Closes #4401
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (92.85%) is below the target coverage (99.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #4406 +/- ##
==========================================
- Coverage 93.96% 93.96% -0.01%
==========================================
Files 401 401
Lines 36892 36902 +10
Branches 13490 13494 +4
==========================================
+ Hits 34667 34676 +9
- Misses 1569 1570 +1
Partials 656 656
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest_missing_testscomputedpassedValidationCountfrom a pure PR-body regex match (hasValidationNote) with zero connection to the PR's real CI results. A confirmed false positive: JSONbored/awesome-claude PR feat(ui): slop-band calibration card on the analytics dashboard (#2196) #4719, a fully-automatedgithub-actions[bot]README-regen PR, got a FAILURE conclusion even though its real CI was fully green, because the templated body never uses "tested"/"validated" wording, and that repo'smanifestPolicy: blockescalated it into a hard blocker.passedValidationCountnow ALSO consults the PR's live CI state (cachedLiveCiAggregate, the same infra the disposition/unified-comment already use) — a fully-green CI rollup counts as evidence, in addition to the existing PR-body text match.ciState === "passed"already excludes gittensory's own Gate/Context check-runs, so this can never be self-referential.manifestPolicyGateModeblock, mirroring the existingreview.auto_review.ignore_authorsglob (reusing the eligibility check already computed for the AI-review skip) — a fully-automated bot PR is no longer held to "did you demonstrate test evidence" scrutiny meant for human contributors.Closes #4401
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlint(unaffected by this diff — no workflow files touched; covered bynpm run test:ci)npm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workers(unaffected by this diff; covered bynpm run test:ci)npm run build:mcpnpm run test:mcp-pack(unaffected by this diff; covered bynpm run test:ci)npm run ui:openapi:check(no API/schema changes)npm run ui:lint(no UI changes)npm run ui:typecheck(no UI changes)npm run ui:build(no UI changes)npm audit --audit-level=moderateRan the full
npm run test:cigate locally; all UI/MCP/workers/schema checks above pass unaffected since this diff only touchessrc/queue/processors.tsandtest/unit/queue.test.ts.Safety
UI Evidencesection below. (N/A — backend-only change, no visible UI)UI Evidence
N/A — backend-only change (no UI, no visible surface).
Notes
resolveManifestPassedValidationCountinsrc/queue/processors.tsonly fetches live CI when the manifest actually configuredtestExpectations, no test file changed, and no PR-body validation note was found — so repos that haven't opted intotestExpectationspay zero extra GitHub calls (byte-identical to before).manifest_missing_testsout ofguidance.findingsitself (not just the advisory-push loop), so the existing E2E-test-generation auto-trigger (feat(review): auto-trigger E2E test generation on the manifest_missing_tests signal #4196) is exempted too, staying consistent with the same "don't scrutinize a bot PR for test evidence" decision.