chore(review): remove never-wired test-generation dead slice - #4126
Conversation
GITTENSORY_REVIEW_TEST_GENERATION, the review.testGeneration manifest field, and their resolver/gate functions (resolveTestGenerationManifestToggle, isTestGenerationEnabled, shouldOfferTestGenerationSpec) had zero callers anywhere in the review pipeline -- the spec-attachment slice that was supposed to consume them was never built. Removes the whole orphaned surface plus its test file and the stale doc mentions in the example configs and docs pages. The live, ungated MCP test-generation tools (gittensory_generate_tests, boundary-test-generation) are untouched.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
gittensory-ui | 8a284a5 | Commit Preview URL Branch Preview URL |
Jul 08 2026, 03:14 AM |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4126 +/- ##
==========================================
- Coverage 93.66% 93.66% -0.01%
==========================================
Files 385 384 -1
Lines 35930 35925 -5
Branches 13185 13182 -3
==========================================
- Hits 33654 33649 -5
Misses 1618 1618
Partials 658 658
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-08 03:25:56 UTC
⏸️ Suggested Action - Manual Review
Review summary Nits — 6 non-blocking
Linked issue satisfactionAddressed Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
GITTENSORY_REVIEW_TEST_GENERATION(src/env.d.ts/wrangler.jsonc), thereview.testGenerationmanifest field (packages/gittensory-engine/src/focus-manifest.ts), and their resolver/gate functions (resolveTestGenerationManifestToggle,isTestGenerationEnabled,shouldOfferTestGenerationSpecinsrc/review/test-generation.ts) had zero real callers anywhere insrc/— the "separate slice" that was supposed to wire a generated test spec onto a missing-test-evidence finding in the live review pipeline was never built.worker-configuration.d.ts), the manifest field's full round-trip (type/parse/present-check/overlay/serialize) inpackages/gittensory-engine/src/focus-manifest.ts,src/review/test-generation.tsand its dedicated test file, and the now-dangling references intest/unit/focus-manifest.test.ts,test/unit/config-templates.test.ts, andtest/unit/signals-coverage.test.ts..gittensory.yml.example,config/examples/gittensory.full.yml, and the twoapps/gittensory-ui/src/routes/docs.privacy-security.tsx/docs.tuning.tsxpages.gittensory_generate_tests, the boundary-test-generation tool insrc/mcp/server.ts/src/mcp/local-write-tools.ts/src/signals/boundary-test-generation.ts) — confirmed via grep that they use entirely separate functions/finding codes before removing anything.Closes #4108
Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Closes #123) — a linked open issue is required for every contributor PR.Validation
git diff --checknpm run actionlint(vianpm run test:ci)npm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workers(vianpm run test:ci)npm run build:mcp(vianpm run test:ci)npm run test:mcp-pack(vianpm run test:ci)npm run ui:openapi:check(vianpm run test:ci)npm run ui:lint(vianpm run test:ci)npm run ui:typecheck(vianpm run test:ci)npm run ui:build(vianpm run test:ci)npm audit --audit-level=moderateRan the full local gate:
npm run test:ci(exit 0 — 580 test files / 11728 tests passed, 2 pre-existing skips,ui:buildsucceeded) andnpm audit --audit-level=moderate(0 vulnerabilities). Every hunk in the diff is a pure deletion (git diff --stat: 9 insertions / 173 deletions across 14 files), so there are no newly-added lines needing fresh coverage; confirmed viagit diffhunk headers that no changed line falls in any pre-existing partially-covered branch range reported bytest:coverage.Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots — skipped: the onlyapps/gittensory-uichanges are removing one stale bullet/line each from two static docs pages describing an env var that was never actually wired into the review pipeline; no new visual state, layout, or component behavior is introduced.Notes
GITTENSORY_REVIEW_TEST_GENERATION,review.testGeneration/test_generation,resolveTestGenerationManifestToggle,isTestGenerationEnabled, orshouldOfferTestGenerationSpec.