chore: remove vestigial GITTENSORY_REVIEW_TEST_GENERATION env var declaration

[JSONbored]

Part of #4092.

Context

Corrected 2026-07-08 (see issue comments for the full investigation): review.testGeneration is NOT already a working config-only gate. The entire slice is dead code — resolveTestGenerationManifestToggle (src/signals/focus-manifest.ts) and shouldOfferTestGenerationSpec (src/review/test-generation.ts) are never called anywhere in src/; the "separate slice" that was supposed to wire a generated spec onto a missing-test-evidence finding was never built. GITTENSORY_REVIEW_TEST_GENERATION (src/env.d.ts) is unread for the same reason — not because the manifest field alone became sufficient.

The only LIVE test-generation code paths are the standalone MCP tools gittensory_generate_tests and the boundary-test-generation tool (src/mcp/server.ts, src/mcp/local-write-tools.ts, src/signals/boundary-test-generation.ts) — both ungated by config or env var. This issue does not touch those; they are unaffected.

Fix — full dead-slice removal

Deleting just the env var would leave isTestGenerationEnabled/shouldOfferTestGenerationSpec/resolveTestGenerationManifestToggle as newly-orphaned dead exports with no story at all, so the fix removes the whole never-wired slice:

• Remove GITTENSORY_REVIEW_TEST_GENERATION from src/env.d.ts (+ regenerate worker-configuration.d.ts via cf-typegen, + wrangler.jsonc vars if present).
• Remove the orphaned resolveTestGenerationManifestToggle (focus-manifest.ts) and the review.testGeneration manifest field it reads (type + parse + present-check + overlay + serialize).
• Remove the orphaned isTestGenerationEnabled/shouldOfferTestGenerationSpec (src/review/test-generation.ts) and its dedicated test file.
• Update .gittensory.yml.example, config/examples/gittensory.full.yml, and the two apps/gittensory-ui/src/routes/docs.* pages that describe the never-shipped behavior as if live.

Deliverables

• GITTENSORY_REVIEW_TEST_GENERATION removed from src/env.d.ts, regenerated worker-configuration.d.ts committed
• review.testGeneration manifest field + resolveTestGenerationManifestToggle removed from focus-manifest.ts (full round-trip: type/parse/present-check/overlay/serialize)
• src/review/test-generation.ts + its test file removed
• Both .gittensory.yml example files and the two docs pages updated to drop the never-shipped key
• A grep confirming zero remaining references anywhere in the repo

Expected outcome

No orphaned config surface (env var OR manifest field OR resolver function) implying a review-pipeline test-generation gate exists when it was never actually wired in. The two live, ungated MCP test-generation tools are unaffected.

Effort

S — dead-code removal across 4-5 files + docs, no behavior change (confirmed zero live callers).

[linear-code]

JSO-3158

[JSONbored]

Correction after re-verification — the issue's central claim is wrong, and the fix scope needs to widen accordingly.

The claim: "review.testGeneration is ALREADY the sole gate for test-generation — a genuinely-already-compliant example."

What's actually there: the entire review.testGeneration slice is dead code, not a working config-only gate.

• resolveTestGenerationManifestToggle (src/signals/focus-manifest.ts) is never called anywhere in src/ — only in its own definition and a sibling JSDoc comment.
• shouldOfferTestGenerationSpec (src/review/test-generation.ts) — which ANDs the manifest toggle with isTestGenerationEnabled/GITTENSORY_REVIEW_TEST_GENERATION — is never called anywhere in src/ either, only in its own file and its own test.
• That module's own header comment admits it: "Config resolution only; the caller that actually builds/attaches the spec to a missing-test-evidence finding is a separate slice" — that separate slice (wiring the spec onto a missing-test-evidence finding in the live review path) was never built.
• The only LIVE test-generation code paths are the standalone MCP tools gittensory_generate_tests and the boundary-test-generation tool (src/mcp/server.ts, src/mcp/local-write-tools.ts, src/signals/boundary-test-generation.ts) — both ungated by .gittensory.yml or any env var, available to any MCP caller.

So GITTENSORY_REVIEW_TEST_GENERATION is unread specifically because the whole config slice it was paired with never got wired into the review pipeline — not because the manifest field alone became sufficient. Docs still describe the never-shipped behavior as if live: env.d.ts, wrangler.jsonc vars, worker-configuration.d.ts, .gittensory.yml.example, config/examples/gittensory.full.yml, and two apps/gittensory-ui/src/routes/docs.* pages.

Revised fix — full dead-slice removal (deleting just the env var would leave isTestGenerationEnabled/shouldOfferTestGenerationSpec/resolveTestGenerationManifestToggle as newly-orphaned dead exports with no story at all):

• Remove GITTENSORY_REVIEW_TEST_GENERATION from src/env.d.ts (+ regenerate worker-configuration.d.ts via cf-typegen, + wrangler.jsonc vars if present).
• Remove the orphaned resolveTestGenerationManifestToggle (focus-manifest.ts) and the review.testGeneration manifest field it reads (type + parse + present-check + overlay + serialize), mirroring how a field gets fully threaded, just in reverse.
• Remove the orphaned isTestGenerationEnabled/shouldOfferTestGenerationSpec (src/review/test-generation.ts) and its dedicated test file, since nothing calls them.
• Update the doc pages and both .gittensory.yml example files to drop the never-shipped testGeneration key.
• A grep confirming zero remaining references anywhere in the repo.

Expected outcome

No orphaned config surface (env var OR manifest field OR resolver function) implying a review-pipeline test-generation gate exists when it was never actually wired in. The two live, ungated MCP test-generation tools are unaffected — this only removes the unshipped review-pipeline integration attempt.

Effort

S — dead-code removal across 4-5 files + docs, no behavior change (confirmed zero live callers).