fix(signals): classify Java protobuf message stubs as generated - #3746
Conversation
Recognize protoc Java .pb.java message stubs in isGeneratedFile alongside the existing grpc-java *Grpc.java service stub matcher. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3746 +/- ##
=======================================
Coverage 93.29% 93.29%
=======================================
Files 317 317
Lines 32347 32347
Branches 11871 11871
=======================================
Hits 30179 30179
Misses 1537 1537
Partials 631 631
🚀 New features to boost your workflow:
|
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-06 07:17:49 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Summary
Extend
isGeneratedFileto recognize protoc Java message stubs (.pb.java), complementing the existing grpc-java*Grpc.javaservice-stub matcher. Includes positive/negativeisGeneratedFile/classifyChangedFileassertions and a classification-table entry.Fixes #3006
Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesisGeneratedFile,classifyChangedFile, and the representative cases tableIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Incremental path-matcher parity for #3006: Java
.pb.javaprotobuf output now classifies asgeneratedviaclassifyChangedFile, so slop signals and candidate-diff heuristics do not treat machine-generated protoc Java as hand-authored source when comparing iteration attempts.Does not deliver the pairwise candidate-selection slice — only closes a generated-classification gap in the shared path-matcher module.
Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3738 enrichment auth circuit-break, #3737 changed_files_summary config test, #3724 local-branch Dart scoring, #3721 automated-review skip hold, #3712 visual shot bounds, #3704 miner calibration types, #3702 miner README, #3698 ignored-author gate).Made with Cursor