Skip to content

test(config): lock in review.changed_files_summary plumbing (#2146) - #3737

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:test/changed-files-summary-2146
Jul 6, 2026
Merged

test(config): lock in review.changed_files_summary plumbing (#2146)#3737
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
luciferlive112116:test/changed-files-summary-2146

Conversation

@luciferlive112116

Copy link
Copy Markdown
Contributor

Closes #2146

Summary

  • Add a config-templates inventory test that locks in the shipped review.changed_files_summary plumbing: docs entry in gittensory.full.yml, manifest parse round-trip, and resolveReviewPromptOverrides boolean helper (unset → false).

Validation

  • npm run typecheck
  • npx vitest run test/unit/config-templates.test.ts

UI Evidence

N/A — test-only.

@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.29%. Comparing base (db8529c) to head (1d322dc).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3737   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         317      317           
  Lines       32347    32347           
  Branches    11871    11871           
=======================================
  Hits        30179    30179           
  Misses       1537     1537           
  Partials      631      631           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 6, 2026
@loopover-orb

loopover-orb Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-06 06:55:20 UTC

1 file · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This is a test-only addition that locks in the existing review.changed_files_summary manifest plumbing: it verifies the docs comment exists in gittensory.full.yml, that parseFocusManifest defaults changedFilesSummary to null, that resolveReviewPromptOverrides collapses unset to false and passes through explicit true/false, and that reviewConfigToJson round-trips the true case. All assertions match already-shipped production behavior rather than introducing new logic, and CI is green across typecheck/tests/coverage. No production code is touched, so there's no functional risk here.

Nits — 4 non-blocking
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2146
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 180 registered-repo PR(s), 94 merged, 18 issue(s).
Contributor context ✅ Confirmed Gittensor contributor luciferlive112116; Gittensor profile; 180 PR(s), 18 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: luciferlive112116
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 180 PR(s), 18 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@loopover-orb
loopover-orb Bot merged commit b6ad8cd into JSONbored:main Jul 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(review): review.changed_files_summary manifest toggle + docs

1 participant