Skip to content

fix(signals): classify C# and Dart gRPC service stubs as generated #3732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jimcody1995 wants to merge 1 commit into from
Closed

fix(signals): classify C# and Dart gRPC service stubs as generated #3732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/signals/path-matchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,12 +81,15 @@ function isGeneratedFileFrom(parts: NormalizedPath): boolean {
// plugin emits `.pb.cr`, the Haskell plugin emits `.pb.hs`, the Scala plugin emits `.pb.scala`, and the Objective-C plugin emits
// `.pbobjc.{h,m}` plus gRPC `.pbrpc.{h,m}` service stubs. Swift gRPC emits sibling `.grpc.swift`
// service stubs; grpc-kotlin emits sibling `*GrpcKt.kt` coroutine service stubs; grpc-java emits
// sibling `*Grpc.java` service stubs.
// sibling `*Grpc.java` service stubs; grpc-dotnet emits sibling `*Grpc.cs` service stubs; the Dart
// gRPC plugin emits sibling `.pbgrpc.dart` service stubs.
// `.pb.dart`/`.pb.kt`/`.pb.cs` (the `.pb` infix keeps hand-written sources from matching).
/\.pb\.(go|ts|js|cc|h|swift|dart|kt|cs|rs|ex|erl|hrl|cr|hs|scala)$/.test(norm) ||
/\.grpc\.swift$/.test(norm) ||
/grpckt\.kt$/.test(norm) ||
/grpc\.java$/.test(norm) ||
/grpc\.cs$/.test(norm) ||
/\.pbgrpc\.dart$/.test(norm) ||
/\.pbobjc\.(h|m)$/.test(norm) ||
/\.pbrpc\.(h|m)$/.test(norm) ||
// Python protobuf: message stubs are `*_pb2.py[i]`; the gRPC plugin emits sibling
Expand Down
11 changes: 11 additions & 0 deletions test/unit/path-matchers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,15 @@ describe("isGeneratedFile", () => {
expect(classifyChangedFile("gen/GreeterGrpcKt.kt")).toBe("generated");
});

it("matches C# and Dart gRPC service stubs alongside the other protoc plugins", () => {
expect(isGeneratedFile("gen/GreeterGrpc.cs")).toBe(true);
expect(isGeneratedFile("lib/foo.pbgrpc.dart")).toBe(true);
expect(isGeneratedFile("src/Greeter.cs")).toBe(false);
expect(isGeneratedFile("lib/user.dart")).toBe(false);
expect(classifyChangedFile("gen/GreeterGrpc.cs")).toBe("generated");
expect(classifyChangedFile("lib/foo.pbgrpc.dart")).toBe("generated");
});

it("matches Java gRPC service stubs alongside the other protoc plugins", () => {
expect(isGeneratedFile("gen/GreeterGrpc.java")).toBe(true);
expect(isGeneratedFile("src/Greeter.java")).toBe(false);
Expand Down Expand Up @@ -524,6 +533,8 @@ describe("classifyChangedFile", () => {
["proto/messages.pb.scala", "generated"],
["gen/GreeterGrpcKt.kt", "generated"],
["gen/GreeterGrpc.java", "generated"],
["gen/GreeterGrpc.cs", "generated"],
["lib/foo.pbgrpc.dart", "generated"],
["gen/service_grpc_pb.js", "generated"],
["gen/service_pb.d.ts", "generated"],
["vendor/lib.go", "vendored"],
Expand Down
Loading