fix(signals): classify C# and Dart gRPC service stubs as generated - #3732
fix(signals): classify C# and Dart gRPC service stubs as generated#3732jimcody1995 wants to merge 1 commit into
Conversation
Recognize grpc-dotnet *Grpc.cs and Dart .pbgrpc.dart service stubs in isGeneratedFile so generated-only diffs classify correctly for slop signals and the changed-files summary classifier. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-06 06:42:25 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
|
Gittensory is closing this pull request on the maintainer's behalf (Linked issue #3724 is assigned to the maintainer (@JSONbored) — that work is reserved for the maintainer, so this PR cannot be auto-accepted.). This is an automated maintenance action — to pursue this change, please open a new pull request with the issues resolved. Closed PRs may be analyzed later to improve review accuracy, but they are not automatically reopened or re-reviewed. |
Summary
Extend
isGeneratedFileto recognize:.pbgrpc.dart) so generated Dart gRPC output is not misclassified as hand-authored source under the.dartcode extension.*Grpc.cs) for parity with existing Java*Grpc.java, KotlinGrpcKt.kt, and Swift.grpc.swiftmatchers.Includes positive/negative
isGeneratedFile/classifyChangedFileassertions and classification-table entries.Fixes #3724
Scope
CONTRIBUTING.md.Validation
git diff --checknpm run test:cion Node 22npm audit --audit-level=moderate— 0 vulnerabilitiesisGeneratedFile,classifyChangedFile, and the representative cases tableIf any required check was skipped, explain why:
Safety
UI Evidence
N/A — signals-only change with no visible UI.
Notes
Advances #3724 by closing a generated-Dart gap:
.pbgrpc.dartgRPC stubs now classify asgeneratedviaisGeneratedFile/classifyChangedFile, alongside existing.g.dart/.freezed.dart/.gr.dartrecognition. C#*Grpc.csis the same class of grpc-plugin service stub parity in the shared path-matcher module.Does not change
isCodeFile/ MCP scoring mirrors — those are covered by the separate open PR for #3724 onlocal-branch.ts.Conflict avoidance: Touches only
src/signals/path-matchers.tsandtest/unit/path-matchers.test.ts. Zero overlap with open PRs (#3724 local-branch scoring, #3718 finding severity floor, #3712 visual shot bounds, #3704 miner calibration types, #3702 miner README, #3698 ignored-author gate).Made with Cursor