fix(signals): classify Dart source across all code classifiers - #3316
Conversation
Extend isCodeFile and advisory isCodePath to recognize .dart so Flutter source aligns with review/rag.ts indexing and receives correct slop, missing-tests, and check-run annotation treatment. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 01:45:30 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 2 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3316 +/- ##
=======================================
Coverage 93.73% 93.73%
=======================================
Files 276 276
Lines 30381 30381
Branches 11073 11073
=======================================
Hits 28479 28479
Misses 1257 1257
Partials 645 645
🚀 New features to boost your workflow:
|
Summary
Dart/Flutter hand-authored source (
.dart) is already indexed as code byreview/rag.tsandtest-evidence.tsrecognizes co-located*_test.dartfiles, butisCodeFileandisCodePathdid not recognize.dart. Flutter-only PRs could be misclassified as non-code in slop signals, missing-tests checks, and check-run annotations.This PR extends both
isCodeFileandisCodePath(plus MCP score-preview mirrors), following the all-classifier parity pattern from #3292 and #3301. Generated Dart (.g.dart,.freezed.dart,.gr.dart) remains non-code viaisGeneratedFile.No linked issue — classifier parity fix with clear product impact.
Conflict avoidance: Touches
src/signals/local-branch.ts,src/signals/engine.ts(only theisCodeFilemirror at ~L5538),src/rules/advisory.ts, MCP mirrors, and unit tests. Open PR #3304 also editsengine.tsbut only around imports (~L29) and unrelated helpers (~L5012) — disjoint hunks, so this should merge cleanly after #3304 lands without rebase. Does not touchtest-evidence.ts(which #3304 modifies). No other open PR overlaps these paths.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciandnpm audit --audit-level=moderateboth passed locally on latestmain(commit 1e9284b).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI change.
Notes
isCodeFile,isCodePath, and MCP mirrors in the same PR.rules.test.tsregression asserts.dartfiles receive missing-test annotations.*_test.dartremains classified as test, not source.