Skip to content

fix(signals): classify Vue/Svelte/Astro across all code classifiers - #3292

Merged
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/signals-vue-svelte-astro-complete
Jul 5, 2026
Merged

fix(signals): classify Vue/Svelte/Astro across all code classifiers#3292
loopover-orb[bot] merged 1 commit into
JSONbored:mainfrom
jimcody1995:fix/signals-vue-svelte-astro-complete

Conversation

@jimcody1995

Copy link
Copy Markdown
Contributor

Summary

Vue, Svelte, and Astro source files were already treated as code by the RAG indexer (review/rag.ts) and the visual-path classifier (review/visual/paths.ts), but two server classifiers still excluded them:

  1. isCodeFile in src/signals/local-branch.ts (slop signals, missing-tests checks, MCP preview)
  2. isCodePath in src/rules/advisory.ts (check-run annotation file filtering)

Prior PRs (#3285, #3282) updated isCodeFile only; the gate closed them because isCodePath still filtered .vue/.svelte/.astro out of annotatableFiles before the missing-tests annotation ran.

This PR updates both classifiers plus the MCP score-preview mirrors, with regression tests in rules.test.ts that assert Vue/Svelte/Astro files receive missing-test annotations.

No linked issue — classifier parity fix with clear product impact.

Conflict avoidance: Touches src/signals/, src/rules/advisory.ts, MCP score-preview mirrors, and unit tests. None of the seven currently open PRs (#3288, #3287, #3286, #3284, #3281, #3278, #3255) modify these paths.

Scope

  • The PR title follows type(scope): short summary Conventional Commit format, for example fix(api): restore profile access checks.
  • This PR is focused and does not mix unrelated backend, UI, MCP, docs, dependency, and deploy changes.
  • This follows CONTRIBUTING.md and does not reintroduce GitHub Pages, VitePress, site/, or CNAME.
  • I linked an issue, or this is small enough that the summary explains why an issue is not needed.

Validation

  • git diff --check
  • npm run actionlint
  • npm run typecheck
  • npm run test:coverage locally; codecov/patch requires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.
  • npm run test:workers
  • npm run build:mcp
  • npm run test:mcp-pack
  • npm run ui:openapi:check
  • npm run ui:lint
  • npm run ui:typecheck
  • npm run ui:build
  • npm audit --audit-level=moderate
  • New or changed behavior has unit/integration tests for new branches, fallback paths, and sanitizer boundaries

If any required check was skipped, explain why:

  • None skipped. Full npm run test:ci and npm audit --audit-level=moderate both passed locally on latest main (commit 3875335).

Safety

  • No secrets, wallet details, hotkeys, coldkeys, user PATs, private keys, raw trust scores, private rankings, or private maintainer evidence are exposed.
  • Public GitHub text stays sanitized, low-noise, and does not imply compensation guarantees or optimization tactics.
  • Auth, cookie, CORS, GitHub App, Cloudflare, or session changes include negative-path tests.
  • API/OpenAPI/MCP behavior is updated and tested where needed.
  • UI changes use live API data or real empty/error/loading states, not production mock/demo fallbacks.
  • Visible UI changes include a UI Evidence section below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.
  • Public docs/changelogs are updated where needed; changelogs are only edited for release-prep PRs.

UI Evidence

N/A — no visible UI change.

Notes

  • Files changed: local-branch.ts, engine.ts, advisory.ts (isCodePath), MCP mirrors, and tests in rules.test.ts, local-branch-file-classifiers.test.ts, local-branch.test.ts, score-preview-script.test.ts.

Extend isCodeFile and advisory isCodePath so front-end framework source
is recognized consistently in slop signals, missing-tests annotations,
and MCP score-preview mirrors — closing the isCodePath gap that blocked
prior partial fixes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jimcody1995
jimcody1995 requested a review from JSONbored as a code owner July 5, 2026 01:03
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@loopover-orb loopover-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jul 5, 2026
@loopover-orb

loopover-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 01:08:14 UTC

10 files · 1 AI reviewer · no blockers · readiness 73/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR brings the changed server and MCP score-preview classifiers into parity for Vue, Svelte, and Astro source files, and the added tests exercise both the local scorer path and the advisory annotation path that previously filtered these files out. The fix is at the right layer for the described missing-test annotation gap because `src/rules/advisory.ts:isCodePath` now admits those paths before annotations are built, while the local/MCP mirrors count the same extensions as source. I do not see a reachable correctness defect in the visible diff, and CI has already passed on this commit.

Nits — 5 non-blocking
  • nit: `src/signals/local-branch.ts:1270` and `src/signals/engine.ts:5538` keep the extension lists manually duplicated, so future parity fixes still require touching several regexes and generated mirrors together.
  • nit: `test/unit/rules.test.ts:789` only asserts the positive annotation path for `.vue`, `.svelte`, and `.astro`; it does not pin that a non-code control remains filtered out in the same regression test.
  • Consider extracting the shared code-extension set used by `src/signals/local-branch.ts` and `src/rules/advisory.ts`, or add a single parity test that compares the classifier decisions directly so future extension drift fails in one place.
  • In `test/unit/rules.test.ts:789`, add one non-code file to the `files` array and assert it receives no `Missing test evidence` annotation, matching the control coverage already used in `test/unit/score-preview-script.test.ts`.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 28 registered-repo PR(s), 12 merged, 0 issue(s).
Contributor context ✅ Confirmed Gittensor contributor jimcody1995; Gittensor profile; 28 PR(s), 0 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: jimcody1995
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 28 PR(s), 0 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.13%. Comparing base (3875335) to head (eb2d295).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3292   +/-   ##
=======================================
  Coverage   94.13%   94.13%           
=======================================
  Files         276      276           
  Lines       30236    30236           
  Branches    11016    11016           
=======================================
  Hits        28464    28464           
  Misses       1127     1127           
  Partials      645      645           
Files with missing lines Coverage Δ
src/rules/advisory.ts 97.25% <100.00%> (ø)
src/signals/engine.ts 97.35% <100.00%> (ø)
src/signals/local-branch.ts 97.21% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@loopover-orb loopover-orb Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant