fix(signals): classify Vue/Svelte/Astro across all code classifiers - #3292
Conversation
Extend isCodeFile and advisory isCodePath so front-end framework source is recognized consistently in slop signals, missing-tests annotations, and MCP score-preview mirrors — closing the isCodePath gap that blocked prior partial fixes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Warning 🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨 ⏸️ Gittensory review result - manual review recommendedReview updated: 2026-07-05 01:08:14 UTC
⏸️ Suggested Action - Manual Review Review summary Nits — 5 non-blocking
Review context
Contributor next steps
Signal definitions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
=======================================
Coverage 94.13% 94.13%
=======================================
Files 276 276
Lines 30236 30236
Branches 11016 11016
=======================================
Hits 28464 28464
Misses 1127 1127
Partials 645 645
🚀 New features to boost your workflow:
|
Summary
Vue, Svelte, and Astro source files were already treated as code by the RAG indexer (
review/rag.ts) and the visual-path classifier (review/visual/paths.ts), but two server classifiers still excluded them:isCodeFileinsrc/signals/local-branch.ts(slop signals, missing-tests checks, MCP preview)isCodePathinsrc/rules/advisory.ts(check-run annotation file filtering)Prior PRs (#3285, #3282) updated
isCodeFileonly; the gate closed them becauseisCodePathstill filtered.vue/.svelte/.astroout ofannotatableFilesbefore the missing-tests annotation ran.This PR updates both classifiers plus the MCP score-preview mirrors, with regression tests in
rules.test.tsthat assert Vue/Svelte/Astro files receive missing-test annotations.No linked issue — classifier parity fix with clear product impact.
Conflict avoidance: Touches
src/signals/,src/rules/advisory.ts, MCP score-preview mirrors, and unit tests. None of the seven currently open PRs (#3288, #3287, #3286, #3284, #3281, #3278, #3255) modify these paths.Scope
type(scope): short summaryConventional Commit format, for examplefix(api): restore profile access checks.CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally;codecov/patchrequires ≥99% coverage of the lines AND branches you changed (aim for 100% on your diff so CI variance does not fail near the threshold). Global coverage is a non-blocking trend with a loose 90% backstop, not the gate.npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
npm run test:ciandnpm audit --audit-level=moderateboth passed locally on latestmain(commit 3875335).Safety
UI Evidencesection below with JPG/JPEG or PNG screenshots arranged as organized, captioned, clickable thumbnails. SVG screenshots are not used as review evidence. Review-only screenshots or recordings are not committed to the repository.UI Evidence
N/A — no visible UI change.
Notes
local-branch.ts,engine.ts,advisory.ts(isCodePath), MCP mirrors, and tests inrules.test.ts,local-branch-file-classifiers.test.ts,local-branch.test.ts,score-preview-script.test.ts.