Skip to content

fix(engine): Maintainer-authored issues can be scored ready for outside contributors #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
glorysr1209-png wants to merge 1 commit into from
Closed

fix(engine): Maintainer-authored issues can be scored ready for outside contributors #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/signals/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1911,6 +1911,9 @@ export function buildIssueQualityReport(
...(linkedWorkCount === 0 ? ["No active PR is linked in cached metadata."] : []),
];
const warnings = [
...(isMaintainerAssociation(issue.authorAssociation)
? ["Issue was opened by a maintainer-associated account."]
: []),
...(bodyLength < 80 ? ["Issue body is thin; contributor may need more proof before acting."] : []),
...(linkedPrs.length > 0 ? [`${linkedPrs.length} active PR(s) already reference this issue.`] : []),
...(linkedMergedPrs.length > 0 ? [`${linkedMergedPrs.length} merged PR(s) already reference this issue.`] : []),
Expand All @@ -1923,6 +1926,8 @@ export function buildIssueQualityReport(
const status: IssueQualityReport["issues"][number]["status"] =
linkedWorkCount > 0 || issueCollisions.some((cluster) => cluster.risk === "high")
? "do_not_use"
: isMaintainerAssociation(issue.authorAssociation)
? "needs_proof"
: warnings.some((warning) => /thin|stale|direct-PR/i.test(warning))
? "needs_proof"
: score < 45
Expand Down