fix(engine): Maintainer-authored issues can be scored ready for outside contributors - #187
Closed
glorysr1209-png wants to merge 1 commit into
Closed
Conversation
JSONbored
requested changes
Jun 1, 2026
Owner
There was a problem hiding this comment.
@glorysr1209-png the maintainer-lane bug is worth fixing, and src/signals/engine.ts is the right behavioral surface.
A few notes:
- The branch conflicts with current
maininsrc/signals/engine.ts. - The check rollup only shows contributor trust/security checks, not a fresh full validate run.
- This area is sensitive because it changes who gets told an issue is ready for outside contribution.
Required changes:
- Resolve the
signals/engineconflict against currentmain. - Add or preserve coverage proving maintainer-authored issues do not get surfaced as ready for outside contributors.
Validation expected:
- Re-run
npm run test:ci. - Confirm signal tests cover maintainer-authored issue handling.
This was referenced Jun 2, 2026
JSONbored
self-requested a review
June 3, 2026 22:18
JSONbored
requested changes
Jun 3, 2026
JSONbored
left a comment
Owner
There was a problem hiding this comment.
@glorysr1209-png this is blocked before code review.
A few notes:
- Maintainer-authored issue handling is a real policy-sensitive surface.
- The branch conflicts in
src/signals/engine.ts. - There is still no passing
validatecheck rollup.
Required changes:
- Rebase on current
mainand resolve the signal engine conflict. - Add/keep a focused unit test proving OWNER/MEMBER/COLLABORATOR authored issues are not treated as ready outside-contributor work unless the policy intends that.
- Update the body to the current template.
Validation expected:
- Focused signal tests
- Full validate pipeline
Owner
|
This is stale, closing - please resubmit with all issues addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #186.
Downgrade maintainer-associated authored issues in issue quality reports.
Changes
src/signals/engine.ts: maintainer warning +needs_proofstatus inbuildIssueQualityReport.Test plan
ready.