Skip to content

fix(engine): Maintainer-authored issues can be scored ready for outside contributors - #187

Closed
glorysr1209-png wants to merge 1 commit into
JSONbored:mainfrom
glorysr1209-png:fix/maintainer-issue-quality
Closed

fix(engine): Maintainer-authored issues can be scored ready for outside contributors#187
glorysr1209-png wants to merge 1 commit into
JSONbored:mainfrom
glorysr1209-png:fix/maintainer-issue-quality

Conversation

@glorysr1209-png

Copy link
Copy Markdown

Summary

Closes #186.

Downgrade maintainer-associated authored issues in issue quality reports.

Changes

  • src/signals/engine.ts: maintainer warning + needs_proof status in buildIssueQualityReport.

Test plan

  • Unit test: OWNER-authored issue is not ready.

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glorysr1209-png the maintainer-lane bug is worth fixing, and src/signals/engine.ts is the right behavioral surface.

A few notes:

  • The branch conflicts with current main in src/signals/engine.ts.
  • The check rollup only shows contributor trust/security checks, not a fresh full validate run.
  • This area is sensitive because it changes who gets told an issue is ready for outside contribution.

Required changes:

  • Resolve the signals/engine conflict against current main.
  • Add or preserve coverage proving maintainer-authored issues do not get surfaced as ready for outside contributors.

Validation expected:

  • Re-run npm run test:ci.
  • Confirm signal tests cover maintainer-authored issue handling.

@JSONbored JSONbored changed the title [Bug]: Maintainer-authored issues can be scored ready for outside contributors fix(engine): Maintainer-authored issues can be scored ready for outside contributors Jun 3, 2026
@JSONbored
JSONbored self-requested a review June 3, 2026 22:18

@JSONbored JSONbored left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@glorysr1209-png this is blocked before code review.

A few notes:

  • Maintainer-authored issue handling is a real policy-sensitive surface.
  • The branch conflicts in src/signals/engine.ts.
  • There is still no passing validate check rollup.

Required changes:

  • Rebase on current main and resolve the signal engine conflict.
  • Add/keep a focused unit test proving OWNER/MEMBER/COLLABORATOR authored issues are not treated as ready outside-contributor work unless the policy intends that.
  • Update the body to the current template.

Validation expected:

  • Focused signal tests
  • Full validate pipeline

@JSONbored

Copy link
Copy Markdown
Owner

This is stale, closing - please resubmit with all issues addressed.

@JSONbored JSONbored closed this Jun 4, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 4, 2026
@JSONbored JSONbored added the gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

[Bug]: Maintainer-authored issues can be scored ready for outside contributors

2 participants