Skip to content

feat(signals): classify remaining config and manifest paths #1691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JSONbored merged 2 commits into from
Jun 28, 2026
Merged

feat(signals): classify remaining config and manifest paths #1691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96f3081
feat(signals): classify remaining path matcher fixtures
tmimmanuel Jun 28, 2026
2bec9a9
Merge branch 'main' into feat/signals-remaining-path-classifiers
JSONbored Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/signals/path-matchers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,11 @@ const DEPENDENCY_MANIFEST_NAMES: ReadonlySet<string> = new Set([
"build.gradle",
"build.gradle.kts",
"pom.xml",
"deno.json",
"deno.jsonc",
"pubspec.yaml",
"mix.exs",
"go.work",
]);

const DOCS_EXTENSIONS: ReadonlySet<string> = new Set(["md", "mdx", "markdown", "rst", "adoc", "asciidoc"]);
Expand Down Expand Up @@ -88,8 +93,33 @@ const CONFIG_FILE_NAMES: ReadonlySet<string> = new Set([
"lefthook.yml",
"lefthook.yaml",
".pre-commit-config.yaml",
".gitleaks.toml",
// Coverage service config.
".codecov.yml",
".codecov.yaml",
"codecov.yml",
"codecov.yaml",
// Task-runner config.
"taskfile.yml",
"taskfile.yaml",
"justfile",
// Docker Compose deploy config.
"docker-compose.yml",
"docker-compose.yaml",
"compose.yml",
"compose.yaml",
"docker-compose.override.yml",
"docker-compose.override.yaml",
"compose.override.yml",
"compose.override.yaml",
// Hosted deploy config.
"caddyfile",
"netlify.toml",
"vercel.json",
"railway.json",
// Hosted CI pipeline definitions (single-file basenames).
".gitlab-ci.yml",
"jenkinsfile",
"azure-pipelines.yml",
"buf.yaml",
"buf.gen.yaml",
Expand Down
71 changes: 68 additions & 3 deletions test/unit/path-matchers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,19 @@ describe("defensive input handling", () => {

describe("isDependencyManifestFile", () => {
it("matches dependency manifests", () => {
for (const path of ["package.json", "Cargo.toml", "go.mod", "requirements.txt", "pyproject.toml", "build.gradle.kts"]) {
for (const path of [
"package.json",
"Cargo.toml",
"go.mod",
"requirements.txt",
"pyproject.toml",
"build.gradle.kts",
"deno.json",
"apps/web/deno.jsonc",
"pubspec.yaml",
"backend/mix.exs",
"go.work",
]) {
expect(isDependencyManifestFile(path)).toBe(true);
}
});
Expand Down Expand Up @@ -187,7 +199,28 @@ describe("isConfigFile", () => {
"mise.toml",
"lefthook.yml",
".pre-commit-config.yaml",
".gitleaks.toml",
".codecov.yml",
".codecov.yaml",
"codecov.yml",
"codecov.yaml",
"Taskfile.yml",
"Taskfile.yaml",
"justfile",
"deploy/docker-compose.yml",
"docker-compose.yaml",
"compose.yml",
"compose.yaml",
"docker-compose.override.yml",
"docker-compose.override.yaml",
"compose.override.yml",
"compose.override.yaml",
"Caddyfile",
"netlify.toml",
"vercel.json",
"railway.json",
".gitlab-ci.yml",
"Jenkinsfile",
"azure-pipelines.yml",
"buf.yaml",
"buf.gen.yaml",
Expand All @@ -199,8 +232,17 @@ describe("isConfigFile", () => {
}
});

it("does not treat renovate-like source names as config", () => {
for (const path of ["src/renovate-helpers.ts", "docs/dependabot-notes.md"]) {
it("does not treat source names or doc near-misses as config", () => {
for (const path of [
"src/renovate-helpers.ts",
"docs/dependabot-notes.md",
"src/compose.ts",
"docs/codecov.yml.md",
"docs/docker-compose.yml.md",
"src/justfile.ts",
"docs/Jenkinsfile.md",
"locks/deno.json.lock",
]) {
expect(isConfigFile(path)).toBe(false);
}
});
Expand Down Expand Up @@ -242,11 +284,34 @@ describe("classifyChangedFile", () => {
["pubspec.lock", "lockfile"],
["ios/Podfile.lock", "lockfile"],
["package.json", "dependency_manifest"],
["deno.json", "dependency_manifest"],
["apps/web/deno.jsonc", "dependency_manifest"],
["pubspec.yaml", "dependency_manifest"],
["mix.exs", "dependency_manifest"],
["go.work", "dependency_manifest"],
["tsconfig.json", "config"],
["vitest.config.ts", "config"],
["wrangler.jsonc", "config"],
["turbo.json", "config"],
["renovate.json", "config"],
["Taskfile.yml", "config"],
["Taskfile.yaml", "config"],
["justfile", "config"],
["docker-compose.yml", "config"],
["docker-compose.yaml", "config"],
["compose.yml", "config"],
["compose.yaml", "config"],
["docker-compose.override.yml", "config"],
["compose.override.yaml", "config"],
["Caddyfile", "config"],
["netlify.toml", "config"],
["vercel.json", "config"],
["railway.json", "config"],
[".codecov.yml", "config"],
["codecov.yml", "config"],
["codecov.yaml", "config"],
[".gitleaks.toml", "config"],
["Jenkinsfile", "config"],
[".github/workflows/ci.yml", "config"],
["test/unit/app.test.ts", "test"],
["README.md", "docs"],
Expand Down
Loading