feat(signals): classify remaining config and manifest paths - #1691
Conversation
|
Tip 🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩 ✅ Gittensory review — safe to merge
✅ Approved — safe to merge Review summary
Nits — 3 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. This change correctly extends the path classifier with the remaining dependency manifests and config basenames, and the implementation fits the existing normalized-basename matching model. The notable detail is that mixed-case user-facing names like Taskfile, Caddyfile, and Jenkinsfile are covered by the lowercasing in normalize(), so the lower-case set entries are correct. The added tests exercise the public matchers and classification path with useful negative near-misses; I do not see a reachable correctness break in the diff. Nits (2)
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1691 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 204 204
Lines 22295 22295
Branches 8053 8053
=======================================
Hits 21310 21310
Misses 408 408
Partials 577 577
🚀 New features to boost your workflow:
|
28369fc to
e8977e7
Compare
e8977e7 to
96f3081
Compare
Summary
Scope
This is a narrow follow-up after #1261 and #1458. Those PRs already landed the shared CI/toolchain and lockfile work; this PR covers the remaining examples from #1421 on top of current main and adds public classifier coverage for each newly added basename.
Fixes #1421
Test plan