Skip to content

fix(selfhost): require ORB_WEBHOOK_SECRET for Orb exporter #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JSONbored wants to merge 2 commits into from
Closed

fix(selfhost): require ORB_WEBHOOK_SECRET for Orb exporter #1246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dd410a
fix(selfhost): require orb webhook secret for export
JSONbored Jun 24, 2026
e94fce4
Merge branch 'main' into codex/fix-orb-export-empty-hmac-key-issue
JSONbored Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/selfhost/orb-collector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,11 @@ export async function exportOrbBatch(
if ((process.env.ORB_AIR_GAP ?? "").toLowerCase() === "true") return 0;

const collectorUrl = process.env.ORB_COLLECTOR_URL ?? "https://orb.gittensory.app/v1/ingest";
const secret = process.env.ORB_WEBHOOK_SECRET ?? "";
const secret = process.env.ORB_WEBHOOK_SECRET;
if (!secret) {
incr("gittensory_orb_export_errors_total");
return 0;
}
const anonymize = (process.env.ORB_ANONYMIZE ?? "true").toLowerCase() !== "false";

const { results } = await db
Expand Down
23 changes: 12 additions & 11 deletions test/unit/selfhost-orb-collector.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ describe("exportOrbBatch()", () => {
});
afterEach(() => {
delete process.env.ORB_ENABLED;
process.env.ORB_WEBHOOK_SECRET = undefined as unknown as string;
delete process.env.ORB_WEBHOOK_SECRET;
delete process.env.ORB_ANONYMIZE;
delete process.env.ORB_AIR_GAP;
delete process.env.ORB_COLLECTOR_URL;
Expand Down Expand Up @@ -228,18 +228,19 @@ describe("exportOrbBatch()", () => {
expect(sigHeader).toMatch(/^sha256=[a-f0-9]{64}$/);
});

it("uses empty-string HMAC key when ORB_WEBHOOK_SECRET is unset (covers ?? '' branch)", async () => {
delete (process.env as NodeJS.Dict<string>)["ORB_WEBHOOK_SECRET"];
it("fails closed when ORB_WEBHOOK_SECRET is unset", async () => {
delete process.env.ORB_WEBHOOK_SECRET;
const db = makeDb();
await recordOrbEvent(db, { repo: "o/r", pr_number: 1, head_sha: "sha", outcome: "merged" });
let sigHeader: string | undefined;
const exported = await exportOrbBatch(db, 200, async (_u, init) => {
sigHeader = (init?.headers as Record<string, string>)?.["x-orb-signature"];
return new Response(null, { status: 200 });
});
expect(exported).toBe(1);
// Signature should still be formed (with empty-string key)
expect(sigHeader).toMatch(/^sha256=[a-f0-9]{64}$/);
const fakeFetch = vi.fn(async () => new Response(null, { status: 200 }));

const exported = await exportOrbBatch(db, 200, fakeFetch);

expect(exported).toBe(0);
expect(fakeFetch).not.toHaveBeenCalled();
expect(await renderMetrics()).toContain("gittensory_orb_export_errors_total");
const rows = (await allRows(db)) as Array<Record<string, unknown>>;
expect(rows[0]?.exported_at).toBeNull();
});

it("defaults ORB_ANONYMIZE to true when unset (covers ?? 'true' branch)", async () => {
Expand Down
Loading