fix(selfhost): require ORB_WEBHOOK_SECRET for Orb exporter - #1246
Closed
JSONbored wants to merge 2 commits into
Closed
fix(selfhost): require ORB_WEBHOOK_SECRET for Orb exporter#1246JSONbored wants to merge 2 commits into
JSONbored wants to merge 2 commits into
Conversation
Contributor
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 94.97% 94.97%
=======================================
Files 177 177
Lines 19806 19809 +3
Branches 7125 7125
=======================================
+ Hits 18811 18814 +3
Misses 397 397
Partials 598 598
🚀 New features to boost your workflow:
|
8 tasks
Owner
Author
|
Superseded by #1257. This PR requires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
exportOrbBatchreturn early whenORB_WEBHOOK_SECRETis unset and increment thegittensory_orb_export_errors_totalmetric instead of defaulting to an empty-string key.test/unit/selfhost-orb-collector.test.tsto delete the secret env var and assert the exporter does not call the collector, leaves rows unexported, and records the error metric.Testing
npm test -- --run test/unit/selfhost-orb-collector.test.tspassed (21 tests) and verifies the new fail-closed path and other exporter behaviors.npm run test:coverage -- --run test/unit/selfhost-orb-collector.test.tsran but coverage remapping failed in the local environment withTypeError: jsTokens is not a function(tooling issue unrelated to logic changes).npm run typecheckfailed in this environment due to missing local native deps/types (pg,ioredis) not present innode_modules, which is unrelated to the change.npm run test:ciexercised the pipeline until the repo-wide typecheck step and failed for the same missing-dependency type errors;npm audit --audit-level=moderatefailed due to the registry audit endpoint returning403.Codex Task