fix(review): pending-CI not safe-to-merge + type labels + visual after-shot self-poll - #1077
Conversation
…unverified → held) The earlier fix downgraded only FAILED CI to Blocked; a PENDING/unverified CI still fell through to the merge verdict and rendered 'Approved — safe to merge' while checks were in progress (chip already said 'CI pending'). deriveUnifiedStatus now downgrades ANY non-passed ciState before the verdict switch: failed→blocked, pending/unverified→held. Only ciState='passed' can render ready/safe-to-merge.
LABELS (C): port reviewbot's auto-label — a new src/settings/pr-type-label.ts derives exactly ONE per-PR TYPE label (gittensor:bug/feature/priority) from the conventional-commit title + changed paths, applied at review time (best-effort, independent of the gate/autonomy/dry-run/CI) next to the context label. gittensory only ever applied the static 'gittensor' context label + the autonomy status labels; the bug/feature/priority system was never ported. Adds removePullRequestLabel to keep the three mutually exclusive. VISUAL (D): the AFTER (preview) cell was a 'loading' placeholder forever when the deploy wasn't live at review time — the only refill was a fragile deployment_status webhook. Add reviewbot's self-poll: capture.previewPending now schedules a delayed 'recapture-preview' job (90s, bounded to MAX_PREVIEW_POLLS) that re-reviews the PR to re-capture the now-ready shot. Bundles the staged pending-CI fix (CI that hasn't passed is never 'safe to merge'). AI review mode set to 'block' (full dual review) in D1 — separate live change.
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Caution 🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥 🛑 Gittensory review — blocked
🛑 Blocked Review summary Suggestions
CI checks failing
Nits — 1 non-blocking
Review context
Contributor next steps
Signal definitions
Review detailsGenerated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative. The pull request introduces several changes, including a new type label system, a visual after-shot self-poll feature, and modifications to the unified comment renderer. The changes appear to be well-structured and follow good coding practices. However, without a thorough review of the entire codebase, it is difficult to assess the overall impact of these changes. Suggestions
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1077 +/- ##
==========================================
- Coverage 94.93% 94.89% -0.05%
==========================================
Files 150 151 +1
Lines 18216 18249 +33
Branches 6601 6610 +9
==========================================
+ Hits 17294 17317 +23
- Misses 413 419 +6
- Partials 509 513 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ghost
left a comment
There was a problem hiding this comment.
Gittensory requests changes — CI is not green:
- CI is failing (codecov/patch, codecov/project)
ghost
left a comment
There was a problem hiding this comment.
Gittensory requests changes — CI is not green:
- CI is failing (codecov/patch, codecov/project)
Bundles the remaining review-pipeline fixes (all deployed: pending-CI
14f83cfe).pr-type-label.tsderives one gittensor:bug/feature/priority per PR by title + changed paths, applied review-time + best-effort.capture.previewPendingnow schedules a boundedrecapture-previewjob (90s ×5) so the AFTER cell refills once the preview deploy is live, instead of a stuck spinner.block(full dual review).3460 tests pass; typecheck clean.