Skip to content

fix(review): pending-CI not safe-to-merge + type labels + visual after-shot self-poll - #1077

Merged
JSONbored merged 2 commits into
mainfrom
fix/pending-ci-not-safe-to-merge
Jun 23, 2026
Merged

fix(review): pending-CI not safe-to-merge + type labels + visual after-shot self-poll#1077
JSONbored merged 2 commits into
mainfrom
fix/pending-ci-not-safe-to-merge

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Bundles the remaining review-pipeline fixes (all deployed: pending-CI 14f83cfe).

  • Pending CI is never 'safe to merge' — deriveUnifiedStatus downgrades any non-passed CI (failed→Blocked, pending/unverified→Held).
  • Type labels (reviewbot auto-label parity) — new pr-type-label.ts derives one gittensor:bug/feature/priority per PR by title + changed paths, applied review-time + best-effort.
  • Visual after-shot self-pollcapture.previewPending now schedules a bounded recapture-preview job (90s ×5) so the AFTER cell refills once the preview deploy is live, instead of a stuck spinner.
  • Separately (live D1): AI review mode set to block (full dual review).

3460 tests pass; typecheck clean.

…unverified → held)

The earlier fix downgraded only FAILED CI to Blocked; a PENDING/unverified CI still fell through to the merge
verdict and rendered 'Approved — safe to merge' while checks were in progress (chip already said 'CI pending').
deriveUnifiedStatus now downgrades ANY non-passed ciState before the verdict switch: failed→blocked,
pending/unverified→held. Only ciState='passed' can render ready/safe-to-merge.
LABELS (C): port reviewbot's auto-label — a new src/settings/pr-type-label.ts derives exactly ONE per-PR TYPE
label (gittensor:bug/feature/priority) from the conventional-commit title + changed paths, applied at review
time (best-effort, independent of the gate/autonomy/dry-run/CI) next to the context label. gittensory only ever
applied the static 'gittensor' context label + the autonomy status labels; the bug/feature/priority system was
never ported. Adds removePullRequestLabel to keep the three mutually exclusive.

VISUAL (D): the AFTER (preview) cell was a 'loading' placeholder forever when the deploy wasn't live at review
time — the only refill was a fragile deployment_status webhook. Add reviewbot's self-poll: capture.previewPending
now schedules a delayed 'recapture-preview' job (90s, bounded to MAX_PREVIEW_POLLS) that re-reviews the PR to
re-capture the now-ready shot. Bundles the staged pending-CI fix (CI that hasn't passed is never 'safe to merge').

AI review mode set to 'block' (full dual review) in D1 — separate live change.
@dosubot dosubot Bot added the size:L label Jun 23, 2026
@superagent-security

Copy link
Copy Markdown
Contributor

Superagent didn't find any vulnerabilities or security issues in this PR.

@ghost

ghost commented Jun 23, 2026

Copy link
Copy Markdown

Caution

🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥🟥

🛑 Gittensory review — blocked

8 files · 2 AI reviewers · no blockers · readiness 93/100 · CI failing · unstable

🛑 Blocked

Review summary
The pull request introduces several changes, including a new type label system, a visual after-shot self-poll feature, and modifications to the unified comment renderer. The changes appear to be well-structured and follow good coding practices. However, without a thorough review of the entire codebase, it is difficult to assess the overall impact of these changes.

Suggestions

  • Consider adding a comment to `removePullRequestLabel` explaining why it ignores 404 errors.
  • Consider adding a comment to `deriveUnifiedStatus` explaining the logic for downgrading CI states.
  • Consider adding a comment to `resolvePrTypeLabel` explaining the priority order of label resolution.

CI checks failing

  • codecov/patch — 71.42% of diff hit (target 94.93%)
  • codecov/project — 94.89% (-0.05%) compared to 1f432e7
Signal Result Evidence
Code review ✅ No blockers 2 reviewers, synthesized
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Review load ✅ 20/20 Readiness component derived from cached public PR metadata and labels; size label size:L.
Validation evidence ✅ 25/25 PR body includes validation/test evidence.
Open PR queue ✅ 10/10 0 open PR(s), 0 likely reviewable.
Contributor context ✅ Confirmed Gittensor contributor JSONbored; Gittensor profile; 85 PR(s), 251 issue(s).
Gate result ✅ Passing No configured blocker found.
Nits — 1 non-blocking
  • No linked issue detected — If this PR is intended to solve an issue, link it explicitly in the PR body.
Review context
  • Author: JSONbored
  • Role context: owner (maintainer lane)
  • Public audience mode: oss maintainer
  • Lane context: Repository is configured for direct PR review.
  • Public profile languages: Python, TypeScript, JavaScript, Ruby, Go, Kotlin, MDX, Shell
  • Official Gittensor activity: 85 PR(s), 251 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Treat this as maintainer-lane context rather than normal contributor-lane activity.
  • Explain no-issue PR.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Review load = cached public PR metadata such as size labels, changed paths, and preflight status.
  • Open PR queue = repo-wide review pressure; it is not a PR quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.
Review details

Generated from public PR metadata and the diff. Advisory only; deterministic signals remain authoritative.

The pull request introduces several changes, including a new type label system, a visual after-shot self-poll feature, and modifications to the unified comment renderer. The changes appear to be well-structured and follow good coding practices. However, without a thorough review of the entire codebase, it is difficult to assess the overall impact of these changes.

Suggestions

  • Consider adding a comment to `removePullRequestLabel` explaining why it ignores 404 errors.
  • Consider adding a comment to `deriveUnifiedStatus` explaining the logic for downgrading CI states.
  • Consider adding a comment to `resolvePrTypeLabel` explaining the priority order of label resolution.
  • Re-run Gittensory review

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

@ghost ghost added gittensory:reviewed gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier. labels Jun 23, 2026

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.89%. Comparing base (1f432e7) to head (863ad12).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/queue/processors.ts 50.00% 7 Missing and 2 partials ⚠️
src/github/labels.ts 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1077      +/-   ##
==========================================
- Coverage   94.93%   94.89%   -0.05%     
==========================================
  Files         150      151       +1     
  Lines       18216    18249      +33     
  Branches     6601     6610       +9     
==========================================
+ Hits        17294    17317      +23     
- Misses        413      419       +6     
- Partials      509      513       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory requests changes — CI is not green:

  • CI is failing (codecov/patch, codecov/project)

@ghost ghost left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory requests changes — CI is not green:

  • CI is failing (codecov/patch, codecov/project)

@JSONbored
JSONbored merged commit 1cc690f into main Jun 23, 2026
17 of 19 checks passed
@JSONbored
JSONbored deleted the fix/pending-ci-not-safe-to-merge branch June 23, 2026 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.05x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant