fix(review): require current-head CI for green chip - #1072
Conversation
|
Superagent didn't find any vulnerabilities or security issues in this PR. |
|
Note 🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦🟦 💡 Gittensory review — advisory only
💡 Advisory only — PR closed before full evaluation. No late first comment was created.
🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed 💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →. Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. |
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
ghost
left a comment
There was a problem hiding this comment.
Gittensory approves — the gate is satisfied and CI is green.
Motivation
CI greenchip when cached check summaries from old head SHAs or partial/pending checks exist.Description
buildMergeReadinessFromChecksinsrc/review/unified-comment-bridge.tsto computeMergeReadinessby filtering cachedCheckSummaryRecords to the PRheadShaand requiring every current-head check be completed successfully before returningciState: "passed".src/queue/processors.tswith a call tobuildMergeReadinessFromChecks({ checks, headSha: pr.headSha, mergeableState: pr.mergeableState })so the unified comment uses current-head-only readiness.failingChecksfield when appropriate.test/unit/unified-comment-bridge.test.tscovering stale success + pending checks, all-current-head-success, and current-head failure cases, and export the new helper for testing.Testing
npx vitest run test/unit/unified-comment-bridge.test.ts, and the suite passed.npm run typecheck(tsc --noEmit), and type checking succeeded.Codex Task