Follow-up to #6073 (closed as confirmed dead by the maintainer: no cloud/hosted deployment is running the review pipeline right now, so the legacy path is unreachable in production).
Scope
Remove buildPublicPrIntelligenceComment (packages/loopover-engine/src/signals/engine.ts, ~5,800 lines including its private helpers) and the LOOPOVER_REVIEW_UNIFIED_COMMENT / LOOPOVER_REVIEW_REPOS cutover-gate branch in src/queue/processors.ts that still selects between it and the converged renderer -- the converged renderer (renderUnifiedReviewComment / buildUnifiedCommentBody) becomes the only path, unconditionally.
Also remove/simplify anything ONLY needed to support the legacy/converged fork:
LOOPOVER_REVIEW_UNIFIED_COMMENT env flag + its checks (isUnifiedReviewCommentEnabled)src/review/cutover-gate.ts (isConvergenceRepoAllowed / listConvergenceRepos) if nothing else reads LOOPOVER_REVIEW_REPOS for a real (non-legacy) purpose -- confirm before deleting, this flag may still gate other converged features independently- The
<!-- gittensory-pr-panel:v1 --> legacy marker and its entry in markerAliases() (src/github/comments.ts) -- keep the alias only if any in-flight comment could still carry it, otherwise drop
buildMinimalInviteComment and any other legacy-only helper in engine.ts confirmed to have no other caller- The now-dead
review.fields filtering duplicate in engine.ts (packages/loopover-engine/src/signals/engine.ts:4530-ish) -- unified-comment-bridge.ts's copy becomes the only one
Before removing
Grep every call site of each function/flag being deleted (not just its own file) -- this repo has ~75 test files referencing focus-manifest/engine.ts machinery, and some legacy-path tests may need deletion rather than updating. Run the full local gate (npm run test:ci) after, not just the directly-affected test files, given the size of the deletion.
Why not done as part of #6065
This is a large (~5,800-line), higher-blast-radius deletion warranting its own scoped PR and explicit review, separate from the comment-redesign epic's incremental UX changes.
Follow-up to #6073 (closed as confirmed dead by the maintainer: no cloud/hosted deployment is running the review pipeline right now, so the legacy path is unreachable in production).
Scope
Remove
buildPublicPrIntelligenceComment(packages/loopover-engine/src/signals/engine.ts, ~5,800 lines including its private helpers) and theLOOPOVER_REVIEW_UNIFIED_COMMENT/LOOPOVER_REVIEW_REPOScutover-gate branch in src/queue/processors.ts that still selects between it and the converged renderer -- the converged renderer (renderUnifiedReviewComment / buildUnifiedCommentBody) becomes the only path, unconditionally.Also remove/simplify anything ONLY needed to support the legacy/converged fork:
LOOPOVER_REVIEW_UNIFIED_COMMENTenv flag + its checks (isUnifiedReviewCommentEnabled)src/review/cutover-gate.ts(isConvergenceRepoAllowed / listConvergenceRepos) if nothing else readsLOOPOVER_REVIEW_REPOSfor a real (non-legacy) purpose -- confirm before deleting, this flag may still gate other converged features independently<!-- gittensory-pr-panel:v1 -->legacy marker and its entry inmarkerAliases()(src/github/comments.ts) -- keep the alias only if any in-flight comment could still carry it, otherwise dropbuildMinimalInviteCommentand any other legacy-only helper in engine.ts confirmed to have no other callerreview.fieldsfiltering duplicate in engine.ts (packages/loopover-engine/src/signals/engine.ts:4530-ish) --unified-comment-bridge.ts's copy becomes the only oneBefore removing
Grep every call site of each function/flag being deleted (not just its own file) -- this repo has ~75 test files referencing focus-manifest/engine.ts machinery, and some legacy-path tests may need deletion rather than updating. Run the full local gate (
npm run test:ci) after, not just the directly-affected test files, given the size of the deletion.Why not done as part of #6065
This is a large (~5,800-line), higher-blast-radius deletion warranting its own scoped PR and explicit review, separate from the comment-redesign epic's incremental UX changes.