Skip to content

investigate: is the legacy comment renderer still needed anywhere? #6073

Description

@JSONbored

Part of #6065. Investigation only -- no code change in this issue.

Problem

Two entirely separate comment-body implementations coexist: the converged renderer (src/review/unified-comment.ts, what every other sub-issue in this epic touches) and a legacy renderer, buildPublicPrIntelligenceComment() (packages/loopover-engine/src/signals/engine.ts:4370, ~5,800-line file), still branded with the <!-- gittensory-pr-panel:v1 --> marker. The switch is in src/queue/processors.ts:9995 -- the legacy path only runs when LOOPOVER_REVIEW_UNIFIED_COMMENT is off OR a repo isn't on the LOOPOVER_REVIEW_REPOS allowlist (src/review/cutover-gate.ts).

None of the redesign work in this epic touches the legacy renderer, meaning any repo still on it won't see any of these improvements, AND review.fields filtering has to be kept in sync in two independently-coded places (unified-comment-bridge.ts:774 and engine.ts:4530) for as long as both exist.

What to check

  • Which repos (if any) are currently NOT on LOOPOVER_REVIEW_REPOS / have LOOPOVER_REVIEW_UNIFIED_COMMENT off, i.e. are still actually rendering via the legacy path in production.
  • Whether there's a reason it was kept around post-cutover (rollback safety net? specific repo compat issue?) -- check git history / related issues around the convergence cutover.

Outcome

  • If confirmed dead (every live repo on the converged path, no rollback dependency): file a SEPARATE maintainer-only/roadmap issue proposing removal of buildPublicPrIntelligenceComment and the legacy code paths that call it. Do not remove it in this issue -- ~5800 lines is a large, separately-scoped change deserving its own PR and explicit go-ahead, not bundled into this epic.
  • If still needed: note why here and close as not-planned.

Metadata

Metadata

Assignees

Labels

maintainer-onlyOwner-only work — yields no Gittensor points.orbGittensory Orb related - maintainer self-hosting analytics.roadmapOn the Wave-2 agent-layer roadmap board (project 9)

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions