Enable Double Filter Input for Temperature Response - #356
Merged
joyvelasquez merged 12 commits intoJul 9, 2025
Merged
joyvelasquez merged 12 commits into
joyvelasquez merged 12 commits into
Conversation
added 5 commits
July 7, 2025 16:49
Contributor
Author
|
pre-commit.ci autofix |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #356 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Contributor
Author
|
For the double filter combinations "C-poly/Ti-poly" and "Al-poly/Ti-poly" under the coronal abundance model, we’ve temporarily loosened the absolute tolerance (atol=1e-4) in the test suite.I added a helper function (get_tolerances_for_filter) to explicitly manage these cases and included a note to revisit this in a future release. The behavior under photospheric and hybrid models remains within tighter tolerances. |
Contributor
Author
|
Close #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the TemperatureResponseFundamental class to support double-filter inputs, just like EffectiveAreaFundamental. Previously, only single filters could be passed. Description will continue to be updated.