Skip to content

Looser Tolerance Required for Temperature Response Tests of Double Filters Under Coronal Abundance #358

Description

@joyvelasquez

Tests for the following double filter combinations:

  • Al-poly/Ti-poly

  • C-poly/Ti-poly

fail when using the default tolerance settings (rtol=0.005, atol=1e-6 * max). These failures only occur under the coronal abundance model, while the same filters pass under both photospheric and hybrid abundances.

As a temporary workaround, we’ve loosened the absolute tolerance to 1e-4 for these filters only under coronal conditions in the test suite. Revisit the tolerance once the source is clearly understood. Orginal PR #356

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions