Skip to content

made sign_in in google_identity_platform_config O+C#9001

Merged
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix_identity_platform_config_sign_in
Sep 19, 2023
Merged

made sign_in in google_identity_platform_config O+C#9001
shuyama1 merged 1 commit into
GoogleCloudPlatform:mainfrom
shuyama1:fix_identity_platform_config_sign_in

Conversation

@shuyama1

Copy link
Copy Markdown
Member

Fixed a bug introduced in #8559

Release Note Template for Downstream PRs (will be copied)

identityplayform: fixed a potential perma-diff for `sign_in` in `google_identity_platform_config` resource

@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 1 deletion(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 3069
Passed tests 2770
Skipped tests: 298
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIdentityPlatformConfig_identityPlatformConfigMinimalExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

@shuyama1 shuyama1 requested review from a team and ScottSuarez and removed request for a team September 19, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants