Move sign_in from google_identity_platform_project_default_config to google_identity_platform_config.

[mraouffouad]

Move sign_in from google_identity_platform_project_default_config to google_identity_platform_config. Mark the former as deprecated. For more context, see #8064.

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
• Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

identityplayform: added `sign-in` field to `google_identity_platform_config` resource

identityplayform: deprecated `google_identity_platform_project_default_config` resource. Use `google_identity_platform_config` resource instead

[modular-magician]

Hello! I am a robot. It looks like you are a community contributor. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 616 insertions(+), 3 deletions(-))
Terraform Beta: Diff ( 5 files changed, 616 insertions(+), 3 deletions(-))
TF Conversion: Diff ( 3 files changed, 225 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2930
Passed tests 2628
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[mraouffouad]

@shuyama1 This PR is waiting for your approval.

[shuyama1]

@mraouffouad Thanks for the ping! Sorry this fell off my radar. Working on the review now.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 615 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 615 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 222 insertions(+))

[shuyama1]

Overall looks good, only some small comments

[modular-magician]

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 615 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 615 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 222 insertions(+))

[modular-magician]

Tests analytics

Total tests: 2939
Passed tests 2637
Skipped tests: 302
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[shuyama1]

Would you mind resolving the merge conflicts in the upgrade guide? Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 222 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3055
Passed tests 2755
Skipped tests: 298
Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIdentityPlatformConfig_update|TestAccDataSourceGoogleServiceAccountJwt

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccDataSourceGoogleServiceAccountJwt[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccIdentityPlatformConfig_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 222 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3056
Passed tests 2757
Skipped tests: 298
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccIdentityPlatformConfig_update

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccIdentityPlatformConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[c2thorn]

add @c2thorn to confirm: do we still accept new PRs for major release at this moment?

We'll accept 5.0.0 PR's until 9/22

[shuyama1]

@mraouffouad Confirmed that the test is passing. Thanks for working on it. Overall looks good. For one last part, would you mind resolving the conflicts in mmv1/third_party/terraform/website/docs/guides/version_5_upgrade.html.markdown? Thanks!

[mraouffouad]

Tests passed during RECORDING mode: TestAccIdentityPlatformConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

No issues found for passed tests after REPLAYING rerun.

All tests passed! View the build log or the debug log for each test

@shuyama1 Tests are passing in VCR. I removed the comment to skip VCR, like the case it was before this PR.

[shuyama1]

Tests passed during RECORDING mode: TestAccIdentityPlatformConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

No issues found for passed tests after REPLAYING rerun.
All tests passed! View the build log or the debug log for each test

@shuyama1 Tests are passing in VCR. I removed the comment to skip VCR, like the case it was before this PR. Hope this is it.

Thanks for working on it. One last thing about the merge conflict though, please see my comments in #8559 (comment)
Thank you so much!

[mraouffouad]

Tests passed during RECORDING mode: TestAccIdentityPlatformConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

No issues found for passed tests after REPLAYING rerun.
All tests passed! View the build log or the debug log for each test

@shuyama1 Tests are passing in VCR. I removed the comment to skip VCR, like the case it was before this PR. Hope this is it.

Thanks for working on it. One last thing about the merge conflict though, please see my comments in #8559 (comment) Thank you so much!

Done. Thanks for reviewing!

@shuyama1 wrt the next PR, should we be removing mmv1/products/identityplatform/ProjectDefaultConfig.yaml and its associated files / docs?

[shuyama1]

Tests passed during RECORDING mode: TestAccIdentityPlatformConfig_update[Debug log]

Rerun these tests in REPLAYING mode to catch issues

No issues found for passed tests after REPLAYING rerun.
All tests passed! View the build log or the debug log for each test

@shuyama1 Tests are passing in VCR. I removed the comment to skip VCR, like the case it was before this PR. Hope this is it.

Thanks for working on it. One last thing about the merge conflict though, please see my comments in #8559 (comment) Thank you so much!

Done. Thanks for reviewing!

@shuyama1 wrt the next PR, should we be removing mmv1/products/identityplatform/ProjectDefaultConfig.yaml and its associated files / docs?

Yes, and see https://googlecloudplatform.github.io/magic-modules/develop/make-a-breaking-change/#make-the-breaking-change-on-feature-branch-major-release-500 for more details on how to make major release breaking change PRs

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 6 files changed, 746 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 1 file changed, 222 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3060
Passed tests 2761
Skipped tests: 299
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[mraouffouad]

`

Created PR #9036.