Skip to content

Migrate breaking change documentation to hugo site#8240

Merged
ScottSuarez merged 10 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:migrate-breaking-change-doc
Jun 30, 2023
Merged

Migrate breaking change documentation to hugo site#8240
ScottSuarez merged 10 commits into
GoogleCloudPlatform:mainfrom
ScottSuarez:migrate-breaking-change-doc

Conversation

@ScottSuarez

@ScottSuarez ScottSuarez commented Jun 29, 2023

Copy link
Copy Markdown
Contributor

Migration of breaking change documentation to our hugo site

image

  • removed auto generation to tpg and tpgb
  • removed auto generation code and pathway (retained ghost pathway to avoid breaking current pipeline)
  • removed version metadata as it is no longer necessary
  • added tests to check that all ids are unique
  • added tests to check that each rule has a corresponding identifier in the hugo site so auto linking continues to work

fixes b/288630851

Release Note Template for Downstream PRs (will be copied)


@ScottSuarez ScottSuarez changed the title Remove doc generation Migrate breaking change documentation to hugo site Jun 29, 2023
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@ScottSuarez
ScottSuarez requested review from a team and shuyama1 and removed request for a team June 29, 2023 22:45
@modular-magician

Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 2834
Passed tests 2536
Skipped tests: 295
Affected tests: 3

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccFilestoreSnapshot_filestoreSnapshotFullExample|TestAccFilestoreInstance_filestoreInstanceBasicExample|TestAccComputeFirewallPolicyRule_multipleRules

Get to know how VCR tests work

@modular-magician

Copy link
Copy Markdown
Collaborator

Tests passed during RECORDING mode:
TestAccFilestoreSnapshot_filestoreSnapshotFullExample[Debug log]
TestAccFilestoreInstance_filestoreInstanceBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

All tests passed after rerunning REPLAYING mode.


Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants