Skip to content

Promote RestoreWorkload resource to GA#16312

Merged
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore
Feb 5, 2026
Merged

Promote RestoreWorkload resource to GA#16312
melinath merged 1 commit into
GoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore

Conversation

@Megha-Bose

@Megha-Bose Megha-Bose commented Feb 5, 2026

Copy link
Copy Markdown
Contributor
backupdr: promote restore support to GA

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 5, 2026
@github-actions github-actions Bot requested a review from melinath February 5, 2026 19:31
@github-actions

github-actions Bot commented Feb 5, 2026

Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@Megha-Bose

Copy link
Copy Markdown
Contributor Author

Adding manual test run logs here as the restore tests could not be added in the CI pipeline. See #16080 for context:

terraform-restore-disk-basic-ga.log
terraform-restore-vm-basic-ga.log
terraform-restore-regional-disk-ga.log
terraform-restore-vm-props-ga.log
terraform-restore-false-delete-ga.log

@modular-magician modular-magician added service/backupdr and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 5, 2026
@modular-magician

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 6902 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 2 files changed, 5 insertions(+), 7 deletions(-))

@modular-magician

Copy link
Copy Markdown
Collaborator

Non-exercised tests

🔴 Tests were added that are GA-only additions and require manual runs:

  • TestAccBackupDRRestoreWorkload_backupDrRestoreWorkloadComputeInstanceBasicExample
  • TestAccBackupDRRestoreWorkload_backupDrRestoreWorkloadComputeInstanceFullExample
  • TestAccBackupDRRestoreWorkload_backupDrRestoreWorkloadDiskBasicExample
  • TestAccBackupDRRestoreWorkload_backupDrRestoreWorkloadRegionalDiskExample
  • TestAccBackupDRRestoreWorkload_backupDrRestoreWorkloadWithoutDeleteExample

Tests analytics

Total tests: 29
Passed tests: 17
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • backupdr

🟢 All tests passed!

View the build log

@melinath

melinath commented Feb 5, 2026

Copy link
Copy Markdown
Member

@melinath

melinath commented Feb 5, 2026

Copy link
Copy Markdown
Member

Adding manual test run logs here as the restore tests could not be added in the CI pipeline. See #16080 for context:

terraform-restore-disk-basic-ga.log terraform-restore-vm-basic-ga.log terraform-restore-regional-disk-ga.log terraform-restore-vm-props-ga.log terraform-restore-false-delete-ga.log

Ah, right, the tests are all skipped.

Thanks for sharing the logs!

@melinath melinath added this pull request to the merge queue Feb 5, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 7340889 Feb 5, 2026
32 checks passed
18811376770 pushed a commit to 18811376770/magic-modules that referenced this pull request Feb 11, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants