Add RestoreWorkload resource with custom create and delete#16080
Conversation
Megha-Bose
commented
Jan 6, 2026
Megha-Bose
commented
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Megha-Bose
force-pushed
the
tf-restore
branch
11 times, most recently
from
4f69b66 to
3565c48
Compare
modular-magician
added
service/backupdr
and removed
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_backup_dr_restore_workload" "primary" {
clear_overrides_field_mask = # value needed
compute_instance_restore_properties {
advanced_machine_features {
enable_uefi_networking = # value needed
visible_core_count = # value needed
}
allocation_affinity {
consume_allocation_type = # value needed
key = # value needed
values = # value needed
}
confidential_instance_config {
enable_confidential_compute = # value needed
}
disks {
auto_delete = # value needed
boot = # value needed
device_name = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
disk_interface = # value needed
disk_size_gb = # value needed
disk_type = # value needed
guest_os_feature {
type = # value needed
}
index = # value needed
initialize_params {
disk_name = # value needed
replica_zones = # value needed
}
kind = # value needed
license = # value needed
mode = # value needed
saved_state = # value needed
source = # value needed
type = # value needed
}
display_device {
enable_display = # value needed
}
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
hostname = # value needed
instance_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
key_revocation_action_type = # value needed
labels {
key = # value needed
value = # value needed
}
min_cpu_platform = # value needed
network_interfaces {
access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
alias_ip_ranges {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
internal_ipv6_prefix_length = # value needed
ip_address = # value needed
ipv6_access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
name = # value needed
network_tier = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
ipv6_access_type = # value needed
ipv6_address = # value needed
network_attachment = # value needed
nic_type = # value needed
queue_count = # value needed
stack_type = # value needed
}
network_performance_config {
total_egress_bandwidth_tier = # value needed
}
params {
resource_manager_tags {
key = # value needed
value = # value needed
}
}
private_ipv6_google_access = # value needed
resource_policies = # value needed
scheduling {
instance_termination_action = # value needed
local_ssd_recovery_timeout {
nanos = # value needed
seconds = # value needed
}
max_run_duration {
nanos = # value needed
seconds = # value needed
}
min_node_cpus = # value needed
node_affinities {
key = # value needed
operator = # value needed
values = # value needed
}
termination_time = # value needed
}
}
disk_restore_properties {
access_mode = # value needed
architecture = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
enable_confidential_compute = # value needed
guest_os_feature {
type = # value needed
}
labels {
key = # value needed
value = # value needed
}
licenses = # value needed
physical_block_size_bytes = # value needed
resource_manager_tags {
key = # value needed
value = # value needed
}
resource_policy = # value needed
storage_pool = # value needed
}
request_id = # value needed
target_resource {
gcp_resource {
gcp_resourcename = # value needed
location = # value needed
type = # value needed
}
}
}
|
Tests analyticsTotal tests: 28 Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
| so that if you must retry your request, the server will know to ignore | ||
| the request if it has already been completed. | ||
| # --- Target Environments (oneof target_environment) --- | ||
| - name: 'computeInstanceTargetEnvironment' |
There was a problem hiding this comment.
Use conflicts with other 2 fields
|
/gcbrun |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_backup_dr_restore_workload" "primary" {
clear_overrides_field_mask = # value needed
compute_instance_restore_properties {
advanced_machine_features {
enable_uefi_networking = # value needed
visible_core_count = # value needed
}
allocation_affinity {
consume_allocation_type = # value needed
key = # value needed
values = # value needed
}
confidential_instance_config {
enable_confidential_compute = # value needed
}
disks {
auto_delete = # value needed
boot = # value needed
device_name = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
disk_interface = # value needed
disk_size_gb = # value needed
disk_type = # value needed
guest_os_feature {
type = # value needed
}
index = # value needed
initialize_params {
disk_name = # value needed
replica_zones = # value needed
}
kind = # value needed
license = # value needed
mode = # value needed
saved_state = # value needed
source = # value needed
type = # value needed
}
display_device {
enable_display = # value needed
}
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
hostname = # value needed
instance_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
key_revocation_action_type = # value needed
labels {
key = # value needed
value = # value needed
}
min_cpu_platform = # value needed
network_interfaces {
access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
alias_ip_ranges {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
internal_ipv6_prefix_length = # value needed
ip_address = # value needed
ipv6_access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
name = # value needed
network_tier = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
ipv6_access_type = # value needed
ipv6_address = # value needed
network_attachment = # value needed
nic_type = # value needed
queue_count = # value needed
stack_type = # value needed
}
network_performance_config {
total_egress_bandwidth_tier = # value needed
}
params {
resource_manager_tags {
key = # value needed
value = # value needed
}
}
private_ipv6_google_access = # value needed
resource_policies = # value needed
scheduling {
instance_termination_action = # value needed
local_ssd_recovery_timeout {
nanos = # value needed
seconds = # value needed
}
max_run_duration {
nanos = # value needed
seconds = # value needed
}
min_node_cpus = # value needed
node_affinities {
key = # value needed
operator = # value needed
values = # value needed
}
termination_time = # value needed
}
}
disk_restore_properties {
access_mode = # value needed
architecture = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
enable_confidential_compute = # value needed
guest_os_feature {
type = # value needed
}
labels {
key = # value needed
value = # value needed
}
licenses = # value needed
physical_block_size_bytes = # value needed
resource_manager_tags {
key = # value needed
value = # value needed
}
resource_policy = # value needed
storage_pool = # value needed
}
request_id = # value needed
target_resource {
gcp_resource {
gcp_resourcename = # value needed
location = # value needed
type = # value needed
}
}
}
|
Tests analyticsTotal tests: 26 Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
modular-magician
added
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_backup_dr_restore_workload" "primary" {
clear_overrides_field_mask = # value needed
compute_instance_restore_properties {
advanced_machine_features {
enable_uefi_networking = # value needed
visible_core_count = # value needed
}
allocation_affinity {
consume_allocation_type = # value needed
key = # value needed
values = # value needed
}
confidential_instance_config {
enable_confidential_compute = # value needed
}
disks {
auto_delete = # value needed
boot = # value needed
device_name = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
disk_interface = # value needed
disk_size_gb = # value needed
disk_type = # value needed
guest_os_feature {
type = # value needed
}
index = # value needed
initialize_params {
disk_name = # value needed
replica_zones = # value needed
}
kind = # value needed
license = # value needed
mode = # value needed
saved_state = # value needed
source = # value needed
type = # value needed
}
display_device {
enable_display = # value needed
}
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
hostname = # value needed
instance_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
key_revocation_action_type = # value needed
labels {
key = # value needed
value = # value needed
}
min_cpu_platform = # value needed
network_interfaces {
access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
alias_ip_ranges {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
internal_ipv6_prefix_length = # value needed
ip_address = # value needed
ipv6_access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
name = # value needed
network_tier = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
ipv6_access_type = # value needed
ipv6_address = # value needed
network_attachment = # value needed
nic_type = # value needed
queue_count = # value needed
stack_type = # value needed
}
network_performance_config {
total_egress_bandwidth_tier = # value needed
}
params {
resource_manager_tags {
key = # value needed
value = # value needed
}
}
private_ipv6_google_access = # value needed
resource_policies = # value needed
scheduling {
instance_termination_action = # value needed
local_ssd_recovery_timeout {
nanos = # value needed
seconds = # value needed
}
max_run_duration {
nanos = # value needed
seconds = # value needed
}
min_node_cpus = # value needed
node_affinities {
key = # value needed
operator = # value needed
values = # value needed
}
termination_time = # value needed
}
}
disk_restore_properties {
access_mode = # value needed
architecture = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
enable_confidential_compute = # value needed
guest_os_feature {
type = # value needed
}
labels {
key = # value needed
value = # value needed
}
licenses = # value needed
physical_block_size_bytes = # value needed
resource_manager_tags {
key = # value needed
value = # value needed
}
resource_policy = # value needed
storage_pool = # value needed
}
request_id = # value needed
target_resource {
gcp_resource {
gcp_resourcename = # value needed
location = # value needed
type = # value needed
}
}
}
|
Tests analyticsTotal tests: 27 Click here to see the affected service packages
Action takenFound 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
🔴 Tests failed during RECORDING mode: 🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR. |
modular-magician
added
the
awaiting-approval
|
A restore operation necessitates a full resource chain including a Backup Vault, Plan, Resource and association, followed by the creation of backup. Continuous integration requires the clean up of all created resources, but Vaults cannot be deleted if they contain backups, and these backups are subject to an enforced retention period of at least one day. We do not yet support the programmatic cleanup of backups via terraform. Therefore, adding manual run logs as proof of functionality: TestAccBackupDRRestoreWorkload_computeInstanceBasic |
modular-magician
removed
the
awaiting-approval
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_backup_dr_restore_workload" "primary" {
clear_overrides_field_mask = # value needed
compute_instance_restore_properties {
advanced_machine_features {
enable_uefi_networking = # value needed
visible_core_count = # value needed
}
allocation_affinity {
consume_allocation_type = # value needed
key = # value needed
values = # value needed
}
confidential_instance_config {
enable_confidential_compute = # value needed
}
disks {
auto_delete = # value needed
boot = # value needed
device_name = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
disk_interface = # value needed
disk_size_gb = # value needed
disk_type = # value needed
guest_os_feature {
type = # value needed
}
index = # value needed
initialize_params {
disk_name = # value needed
replica_zones = # value needed
}
kind = # value needed
license = # value needed
mode = # value needed
saved_state = # value needed
source = # value needed
type = # value needed
}
display_device {
enable_display = # value needed
}
guest_accelerators {
accelerator_count = # value needed
accelerator_type = # value needed
}
hostname = # value needed
instance_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
key_revocation_action_type = # value needed
labels {
key = # value needed
value = # value needed
}
min_cpu_platform = # value needed
network_interfaces {
access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
alias_ip_ranges {
ip_cidr_range = # value needed
subnetwork_range_name = # value needed
}
internal_ipv6_prefix_length = # value needed
ip_address = # value needed
ipv6_access_configs {
external_ip = # value needed
external_ipv6 = # value needed
external_ipv6_prefix_length = # value needed
name = # value needed
network_tier = # value needed
public_ptr_domain_name = # value needed
set_public_ptr = # value needed
type = # value needed
}
ipv6_access_type = # value needed
ipv6_address = # value needed
network_attachment = # value needed
nic_type = # value needed
queue_count = # value needed
stack_type = # value needed
}
network_performance_config {
total_egress_bandwidth_tier = # value needed
}
params {
resource_manager_tags {
key = # value needed
value = # value needed
}
}
private_ipv6_google_access = # value needed
resource_policies = # value needed
scheduling {
instance_termination_action = # value needed
local_ssd_recovery_timeout {
nanos = # value needed
seconds = # value needed
}
max_run_duration {
nanos = # value needed
seconds = # value needed
}
min_node_cpus = # value needed
node_affinities {
key = # value needed
operator = # value needed
values = # value needed
}
termination_time = # value needed
}
}
disk_restore_properties {
access_mode = # value needed
architecture = # value needed
disk_encryption_key {
kms_key_name = # value needed
kms_key_service_account = # value needed
raw_key = # value needed
rsa_encrypted_key = # value needed
}
enable_confidential_compute = # value needed
guest_os_feature {
type = # value needed
}
labels {
key = # value needed
value = # value needed
}
licenses = # value needed
physical_block_size_bytes = # value needed
resource_manager_tags {
key = # value needed
value = # value needed
}
resource_policy = # value needed
storage_pool = # value needed
}
request_id = # value needed
target_resource {
gcp_resource {
gcp_resourcename = # value needed
location = # value needed
type = # value needed
}
}
}
|
Non-exercised tests🔴 Tests were added that are skipped in VCR:
Tests analyticsTotal tests: 27 Click here to see the affected service packages
🔴 Errors occurred during REPLAYING mode. Please fix them to complete your PR. View the build log |
42fadcc
5 participants
