Skip to content

fix: resolve relative paths in emulator smoke test scripts#645

Open
immanuwell wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
immanuwell:fix/test-script-relative-paths
Open

fix: resolve relative paths in emulator smoke test scripts#645
immanuwell wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
immanuwell:fix/test-script-relative-paths

Conversation

@immanuwell

Copy link
Copy Markdown

Tiny shell paper cut fix.

These smoke-test helpers call sibling scripts with ./..., so from repo root they blow up with No such file or directory before the emulator checks even start. Kinda annoying, pretty easy fix tho.

Repro:

bash ./test-latest.sh
bash ./debian_component_based/test-components.sh

This patch resolves helper paths from each script's own directory, so the same commands work from repo root and from inside the subdirs too. Low risk, just path plumbing really.

Checked:

  • bash -n on the touched scripts
  • mocked runs of both helper chains from repo root
  • mocked run of emulators/test-all-emulators.sh from inside emulators/

Related context: #506, #593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant