fix: resolve relative paths in emulator smoke test scripts#645
Open
immanuwell wants to merge 1 commit into
Open
fix: resolve relative paths in emulator smoke test scripts#645immanuwell wants to merge 1 commit into
immanuwell wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny shell paper cut fix.
These smoke-test helpers call sibling scripts with
./..., so from repo root they blow up withNo such file or directorybefore the emulator checks even start. Kinda annoying, pretty easy fix tho.Repro:
This patch resolves helper paths from each script's own directory, so the same commands work from repo root and from inside the subdirs too. Low risk, just path plumbing really.
Checked:
bash -non the touched scriptsemulators/test-all-emulators.shfrom insideemulators/Related context: #506, #593