Skip to content

Add smoke tests for components installed in the emulators and latest docker image #506

Closed
anindyatahsin wants to merge 7 commits into
masterfrom
smoke-test
Closed

Add smoke tests for components installed in the emulators and latest docker image #506
anindyatahsin wants to merge 7 commits into
masterfrom
smoke-test

Conversation

@anindyatahsin

@anindyatahsin anindyatahsin commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

Add smoke tests for components installed in the emulators, debian_component_based and latest docker images

@cloudsdkdocker cloudsdkdocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I feel like this is on the right track. My concerns are that this testing will affect the eventual images that are built, are we confident that executing all these steps doesn't affect the images/environment in any way? Have we tested the size changes?

Is there a way to run these tests without running them directly in the existing images? Could we extend the existing images and build those extensions in the daily cloud build dry run instead to avoid negative impacts?

Comment thread debian_component_based/emulator-testing.sh
Comment thread debian_component_based/emulator-testing.sh
…he images we copy the relevant Dockerfiles and test with docker images including testing
@anindyatahsin

Copy link
Copy Markdown
Contributor Author

Overall I feel like this is on the right track. My concerns are that this testing will affect the eventual images that are built, are we confident that executing all these steps doesn't affect the images/environment in any way? Have we tested the size changes?

Is there a way to run these tests without running them directly in the existing images? Could we extend the existing images and build those extensions in the daily cloud build dry run instead to avoid negative impacts?

Based on the suggestion moved out the test Dockerfile in a separate location and will only be used when during the docker image testing.

@anindyatahsin

Copy link
Copy Markdown
Contributor Author

Creating a new pull request for smoke testing gcloud cli docker images. So closing this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants