Repository navigation
Chore: Markdown formatting while running lint command - #964
Merged
Merged
Conversation
khushal87
force-pushed
the
khushal87-markdown-prettier
branch
from
November 2, 2021 11:42
40cc813 to
8a70173
Compare
khushal87
marked this pull request as ready for review
November 2, 2021 11:54
madsroskar
suggested changes
Nov 2, 2021
madsroskar
left a comment
madsroskar
left a comment
Contributor
There was a problem hiding this comment.
It doesn't make much sense to me that we have the CI format the files rather than checking whether they have already been formatted. Can we change that?
Contributor
This should be labeled |
refactor: Use JSX rather than React.createElement
madsroskar
reviewed
Nov 11, 2021
build: Remove e2e workflows as they're not stable enough
Next Release
Bumps [tmpl](https://github.com/daaku/nodejs-tmpl) from 1.0.4 to 1.0.5. - [Release notes](https://github.com/daaku/nodejs-tmpl/releases) - [Commits](https://github.com/daaku/nodejs-tmpl/commits/v1.0.5) --- updated-dependencies: - dependency-name: tmpl dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tar](https://github.com/npm/node-tar) from 6.1.8 to 6.1.11. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v6.1.8...v6.1.11) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Mads Røskar <mads.roskar@getstream.io>
fix: render attachment type video in FileAttachment view [CRNS-480]
Next Release
…e/tmpl-1.0.5 build(deps): bump tmpl from 1.0.4 to 1.0.5 in /package
…e/tar-6.1.11 build(deps): bump tar from 6.1.8 to 6.1.11 in /package
Contributor
|
@khushal87 Could you check out the conflicts here? |
khushal87
force-pushed
the
khushal87-markdown-prettier
branch
from
November 22, 2021 12:47
a8dbfc9 to
1da94cd
Compare
…e into khushal87-markdown-prettier
…ream-chat-react-native into khushal87-markdown-prettier
…e into khushal87-markdown-prettier
vishalnarkhede
approved these changes
Nov 22, 2021
Contributor
|
🎉 This PR is included in version 3.10.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
The markdown in the
docusaurusdirectory is not well-formatted and introducing a prettier command to format the files makes sense. So, this is introduced in this pull request.🛠 Implementation details
This works by adding the command
npx prettier --write '**/*.mdx'while we runyarn lintcommand. The command is also introduced in the workflow files and therefore would check and format the files during the workflow.🎨 UI Changes
iOS
Android
🧪 Testing
NA
☑️ Checklist
developbranch