Repository navigation
fix: render attachment type video in FileAttachment view [CRNS-480] - #999
Merged
Merged
Conversation
madsroskar
approved these changes
Nov 15, 2021
vishalnarkhede
changed the title
Contributor
Author
|
🎉 This PR is included in version 3.10.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
RN SDK currently doesn't support video rendering. And thus when user uploads a video, it gets sent as
attachment.type === 'file'. But when file gets uploaded from other SDKs, it gets sent as typevideo, and handling of this case was wrong within the SDK. It used to get rendered asCardcomponent instead of FileAttachment.https://getstream.slack.com/archives/C02888QAYG0/p1636955394060400
🛠 Implementation details
Render type
videoattachment as file attachment.🎨 UI Changes
🧪 Testing
Upload video file from react application and check it on react-native example app.
P.S. We currently have a task to ensure attachment consistency across SDKs, so automated tests will be taken care of as part of that story.