Skip to content

feat: image attachment optimisation [CRNS-474, CRNS-443] - #1056

Merged
vishalnarkhede merged 48 commits into
v4.0.0-beta.2from
vishal/image-resizing
Jan 12, 2022
Merged

feat: image attachment optimisation [CRNS-474, CRNS-443]#1056
vishalnarkhede merged 48 commits into
v4.0.0-beta.2from
vishal/image-resizing

Conversation

@vishalnarkhede

@vishalnarkhede vishalnarkhede commented Dec 17, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Implementation is based on specs drawn out in following doc - https://gist.github.com/vishalnarkhede/6eed1e52b74547f71da8a5757b27c43d

🎯 Goal

🛠 Implementation details

  • Plenty of utility functions have been introduced, but the main entry point or logic for generating the gallery of dynamic image sizes and grid is in buildGallery.ts

🎨 UI Changes

Before After
Screenshot 2021-12-29 at 14 19 25 Screenshot 2021-12-29 at 14 20 09
Screenshot 2021-12-29 at 14 22 10 Screenshot 2021-12-29 at 14 21 49
Screenshot 2021-12-29 at 14 40 29 Screenshot 2021-12-29 at 14 39 36

🧪 Testing

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Commits follow the conventional commits spec
  • New code is covered by tests
  • Screenshots added for visual changes
  • Documentation is updated

madsroskar and others added 13 commits December 3, 2021 18:58
@madsroskar
docs: Fix broken links
60d60ed 
This fixes a few broken links reported by docusaurus
@madsroskar @vishalnarkhede
dox: Fix typo
23305ad 
Co-authored-by: Vishal Narkhede <vishalnarkhede.iitd@gmail.com>
@vishalnarkhede
Merge pull request #1050 from GetStream/khushal87-crns-493
10efd85 
fix: Mentioned users removed after editing message [CRNS - 493]
@petyosi
chore(): fix eslint node errors
ee8b07c
@petyosi
chore(): fix eslint key order
0834e65
@petyosi
chore(): upgrade ts eslint
e6928d7 
Fixes some false positives.
@petyosi
chore(): eslint import plugin passes with default settings
88e8a65
@petyosi
chore(): import order config
c6bafcf
@petyosi
chore(): apply automated import reorder
bf1cc2b
@petyosi
chore(): cleanup whitespace
8b9ff6c
@vishalnarkhede
Merge pull request #1055 from GetStream/fix-eslint
a267858 
chore: fix eslint [CRNS-403]
@vishalnarkhede
feat: image attachment optimization
441b7a1
@vishalnarkhede
Merge branch 'v4.0.0-beta.2' of github.com:GetStream/stream-chat-reac…
a306daf 
…t-native into vishal/image-resizing
@vishalnarkhede vishalnarkhede changed the title feat: image attachment optimisation feat: image attachment optimisation [CRNS-474, CRNS-443] Dec 17, 2021
@vishalnarkhede
vishalnarkhede force-pushed the vishal/image-resizing branch 5 times, most recently from 410cc9f to 7ce935d Compare December 17, 2021 09:50
@vishalnarkhede vishalnarkhede changed the title feat: image attachment optimisation [CRNS-474, CRNS-443] feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] Dec 17, 2021
@vishalnarkhede vishalnarkhede self-assigned this Dec 20, 2021
@madsroskar madsroskar changed the title feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] updating-to-trigger-wf Dec 30, 2021
@madsroskar madsroskar changed the title feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] updating-to-trigger-wf feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] Dec 30, 2021
@madsroskar madsroskar changed the title feat: [WIP] image attachment optimisation [CRNS-474, CRNS-443] feat: image attachment optimisation [CRNS-474, CRNS-443] Dec 30, 2021
@madsroskar

madsroskar commented Dec 30, 2021

Copy link
Copy Markdown
Contributor

Sorry for the extra commits Vish - wanted to get the checks running properly. You can squash my commits into one, but I don't wanna force push on your branch without having a chat first :D

vishalnarkhede
vishalnarkhede commented Jan 3, 2022
View reviewed changes
Comment thread package/src/contexts/overlayContext/OverlayProvider.tsx
overlayOpacity={overlayOpacity}
visible={overlay === 'gallery'}
/>
{overlay === 'gallery' && (

@vishalnarkhede vishalnarkhede Jan 3, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to avoid rendering ImageGallery when overlay is not active

@madsroskar
madsroskar self-requested a review January 3, 2022 15:51
@vishalnarkhede
vishalnarkhede force-pushed the vishal/image-resizing branch 3 times, most recently from ed85336 to 5438b8b Compare January 7, 2022 11:48
@vishalnarkhede
vishalnarkhede merged commit 3260636 into v4.0.0-beta.2 Jan 12, 2022
@vishalnarkhede
vishalnarkhede deleted the vishal/image-resizing branch January 12, 2022 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@madsroskar madsroskar Awaiting requested review from madsroskar

Assignees

@vishalnarkhede vishalnarkhede

Labels

Performance User Experience

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vishalnarkhede @madsroskar @petyosi