Repository navigation
Fix: Mentioned users removed after editing message [CRNS - 493] - #1050
Merged
Merged
Conversation
Contributor
|
Thanks for adding the recording 🙌🏻 And nice catch! I'll drop a link to this PR in a card on our trello for when we get e2e tests set up again so we can consider this case there too :) |
| const mentionedUsers = message.mentioned_users.map((user) => user.id); | ||
| setMentionedUsers(mentionedUsers); | ||
| } | ||
| }, [message]); |
Contributor
There was a problem hiding this comment.
Suggested change
| }, [message]); | |
| }, [messageValue]); |
Will this work as well? Generally its better to avoid objects as hook dependency
Contributor
Author
There was a problem hiding this comment.
I will have to check. Give me some time. 🤞
vishalnarkhede
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Goal
This PR fixes the empty mentioned users array issue when a message with a mentioned user is edited.
Fixes: #1023
Reference ticket: https://stream-io.atlassian.net/browse/CRNS-493
🛠 Implementation details
The solution is fixed in
useEffecthook.📹 Video
Screen.Recording.2021-12-10.at.13.24.42.mov
🎨 UI Changes
iOS
Android
🧪 Testing
☑️ Checklist
developbranch