refactor(settings): land gh-#406 slices 4+5 on main (stacked-PR base-retarget catch) - #513
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🪤 The catch: #511 and #512 show MERGED, but they merged into this branch (
refactor/gh-406-s3-settings-repository), not main — GitHub never retargeted them because it won't auto-delete a branch that is still the base of an open PR, so after #510 went in, their base stayed here. Main today still carries the Provider + SeedMarker baseline rows, and #406 stayed open.📦 This PR is purely those already-reviewed merges reaching main — the branch is exactly
main+ slice 4 (afbd15c, seed marker →ExistsAsync) + slice 5 (27ebc78, boot config provider → syncReadAllForBoot()), nothing else. Diff vs main: 5 files, +221/−70. Merging this closes #406 withExemptionBaselineat its end state — the two designed composition-root rows, zero debt.✅ Re-validated at this exact tip (first contact of slices 4+5 with the #501–#507 merges): build 0 warnings; Architecture 104/104 (L2 sees only the designed exemptions); Host settings+seed-filtered 199/199; StationSettingsRepository db specs 15/15.
Closes #406.