refactor(settings): the boot config provider reads through StationSettingsRepository (gh-#406 slice 5) - #512
Merged
genwave-radio merged 1 commit intoAug 14, 2026
Conversation
…tingsRepository (gh-#406 slice 5)
Base automatically changed from
refactor/gh-406-s4-seed-marker
to
refactor/gh-406-s3-settings-repository
August 14, 2026 01:48
genwave-radio
merged commit Aug 14, 2026
7478107
into
refactor/gh-406-s3-settings-repository
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gh-#406 L2 burn-down, slice 5 of 5 — stacked on slice 4 (merge in order; merge commits, not squash). Merging this completes the issue: the L2 baseline is down to the two designed composition-root exemptions, zero debt rows.
⚖️ The "needs a design" entry, resolved as scoped: the law is about where Npgsql lives, not how the caller is built.
StationSettingsConfigurationProvider.Load()(sync, pre-DI, theIConfigurationProvidercontract) now constructsnew StationSettingsRepository(connectionString)itself — the exact boot path slice 3's plain-string ctor was designed for — and calls the new syncReadAllForBoot()(SQL byte-identical, documented as the deliberate sync exception).using Npgsqlgone; theNpgsqlExceptioncatch becomesDbException(same translation slice 3 documented — identical failures caught, cancellation still propagates).🛡️ Boot posture byte-identical: empty-connection-string short-circuit, allowlist filtering, scalar/array expansion, and catch-log-continue-with-empty-overlay all untouched — only the row fetch moved. Field check after deploy: the config boot echo in Loki should read exactly as before.
📉 Baseline: last debt row deleted;
ExemptionBaseline's header rewritten to the end state (two designed rows, the five debt rows recorded as burned down via gh-#406, "not on this list still fails" retained).✅ At this tip: build 0 warnings; Architecture 104/104 (L2 sees only the designed exemptions); MediaLibrary 769/769 full; Host settings-filtered 167/167 + seed-filtered 37/37.