Skip to content

docs: update codebase concerns and structure maps#390

Merged
FSM1 merged 5 commits into
mainfrom
docs/update-codebase-map
Mar 29, 2026
Merged

docs: update codebase concerns and structure maps#390
FSM1 merged 5 commits into
mainfrom
docs/update-codebase-map

Conversation

@FSM1

@FSM1 FSM1 commented Mar 29, 2026

Copy link
Copy Markdown
Owner

Summary

  • Updated CONCERNS.md and STRUCTURE.md in .planning/codebase/ to reflect phases 28-33 completion
  • Removed 4 resolved concerns (console.log pervasiveness, web observability gap, monolithic files, sync FilePointer resolution on both platforms)
  • Added new concerns: residual console.time in web3auth hooks, mutex unwrap() in FUSE code, fire-and-forget IPNS unenrollment
  • Structure updated for Phase 31 decomposition and new modules from Phases 28/30

Test plan

  • Review CONCERNS.md for accuracy against current codebase
  • Review STRUCTURE.md directory layout matches actual structure

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Revised codebase architecture, directory and CI/test guidance, and refreshed audit/analysis dates.
    • Clarified unenrollment behavior: web-to-SDK delegated unenrollments and a persisted unenrollment queue to retry on next session; noted silent unenrollment risk if a session closes mid-request.
    • Narrowed web auth/logging concerns and documented remaining typing and observability items.

Resolved concerns: console.log pervasiveness (Phase 28), web observability
gap (Phase 30), monolithic files (Phase 31), sync FilePointer resolution
on both macOS (Phase 32) and Windows (Phase 33).

New concerns: residual console.time in web3auth hooks, mutex unwrap()
in FUSE production code, fire-and-forget IPNS unenrollment.

Structure updated to reflect Phase 31 decomposition and new modules
from Phases 28/30.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 2175e40a6fd7
@coderabbitai

coderabbitai Bot commented Mar 29, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@FSM1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 30 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 22 minutes and 30 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cdab84a0-bcf7-42a9-aaf0-5080669a11fe

📥 Commits

Reviewing files that changed from the base of the PR and between d3687fc and faced2d.

📒 Files selected for processing (16)
  • .learnings/2026-02-16-ephemeral-jwks-web3auth-caching.md
  • .planning/DEFERRED.md
  • .planning/baselines/19-someguy-ipns-baselines.md
  • .planning/baselines/19.2-post-optimization-baselines.md
  • .planning/baselines/19.2-pre-optimization-baselines.md
  • .planning/baselines/21-byo-baselines.md
  • .planning/codebase/STRUCTURE.md
  • .planning/debug/resolved/corekit-auth-uat.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-01-PLAN.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-02-PLAN.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-02-SUMMARY.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-04-PLAN.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-RESEARCH.md
  • .planning/phases/19.2-ipfs-upload-performance-optimization/19.2-VERIFICATION.md
  • .planning/todos/done/2026-03-23-investigate-someguy-ipns-routing-failure-locally.md
  • .planning/todos/pending/2026-03-23-investigate-removal-of-mock-ipns-routing-layer.md

Walkthrough

Updated planning documentation: CONCERNS.md revises IPNS unenrollment flow, Web3Auth notes, and FUSE/Mutex concerns; STRUCTURE.md updates analysis date, normalizes naming, refines backend/desktop/web layout and test/CI descriptions, and adds a Hook Inventory section.

Changes

Cohort / File(s) Summary
Concerns Documentation
.planning/codebase/CONCERNS.md
Rewrote IPNS unenrollment concern to describe SDK-delegated unenroll via fireAndForgetUnenroll() and persisting unenroll queue in IndexedDB; narrowed web-app concerns to Web3Auth-specific items (unguarded console.time calls and two any casts); removed several obsolete concerns; adjusted FUSE/Mutex panic notes, platform line counts, unit-test gap targets, and audit phrasing.
Structure Documentation
.planning/codebase/STRUCTURE.md
Updated analysis date; normalized service/dir naming (e.g., jwt-issuer), added IPFS provider submodules and tests, clarified NestJS/TypeORM migration semantics, revised Tauri/Rust layout and vendor paths, expanded web app lib/components/routes/stores docs (api config, logger, Faro, errors, logout cleanup), standardized styling guidance, clarified test-suite and CI/infra listings, and added "Hook Inventory (Phase 31 Decomposition)".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: updates to two documentation files (CONCERNS.md and STRUCTURE.md) in the codebase planning directory.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/update-codebase-map

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

FSM1 and others added 4 commits March 29, 2026 01:34
POC directory was archived to git history in Phase 28 (ee9bcd4).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 4ac62c4de114
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 790b9ad36fe6
Replace 192.168.133.114 references with <docker-host> across 15
planning, baseline, and learnings files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: 12570f1a8c6c
Remove phase references and 'generated' annotations from status column.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Entire-Checkpoint: e2da5bb45c79
@FSM1 FSM1 merged commit 451479b into main Mar 29, 2026
16 checks passed
@FSM1 FSM1 deleted the docs/update-codebase-map branch March 29, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant